Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ruamel.yaml deprecation warnings #215

Closed
ipspace opened this issue Dec 11, 2021 · 3 comments
Closed

ruamel.yaml deprecation warnings #215

ipspace opened this issue Dec 11, 2021 · 3 comments
Labels
enhancement

Comments

@ipspace
Copy link
Contributor

ipspace commented Dec 11, 2021

ruamel.yaml is (very loudly) telling me that the old API is going away (more details @ https://yaml.readthedocs.io/en/latest/api.html), so it might be a good idea to fix that ahead of a breaking change.

I could try to whip up a rudimentary implementation if there's no-one else working on this.
@cdgriffith cdgriffith mentioned this issue Jan 9, 2022
Closed
cdgriffith added a commit that referenced this issue Jan 10, 2022
@cdgriffith
* Adding support for sliceable boxes (thanks to Dias)
0979451 
* Changing #215 support ruamel.yaml new syntax (thanks to Ivan Pepelnjak)
@cdgriffith
Copy link
Owner

cdgriffith commented Jan 21, 2022 •
edited

Adding these features in 6.0, currently have a release candidate that can be installed and tested with:

pip install python-box[all]==6.0.0rc2 --upgrade

6.0 is ushering in Cython speedups on supported platforms, so please let me know if you run into any issues!

Will require ruamel.yaml 0.17+ in Box 6.0+

@ipspace
Copy link
Contributor Author

ipspace commented Jan 22, 2022

Great news, thank you!

Ran all my tests with 6.0.0rc2 (~100 pretty tests of a pretty convoluted code heavily relying on Box) and they passed with flying colors. Will add a few more box-specific tests to my test suite based on how I use the features.

@cdgriffith cdgriffith mentioned this issue Mar 12, 2022
Merged
cdgriffith added a commit that referenced this issue Mar 15, 2022
@cdgriffith
Version 6.0.0 (#216)
985df83 
* Adding Cython support to greatly speed up normal Box operations on supported systems
* Adding #161 support for access box dots with `get` and checking with `in` (thanks to scott-createplay)
* Adding #183 support for all allowed character sets (thanks to Giulio Malventi)
* Adding #196 support for sliceable boxes (thanks to Dias)
* Adding #164 default_box_create_on_get toggle to disable setting box variable on get request (thanks to ipcoder)
* Changing #208 __repr__ to produce `eval`-able text (thanks to Jeff Robbins)
* Changing #215 support ruamel.yaml new syntax (thanks to Ivan Pepelnjak)
* Changing `update` and `merge_update` to not use a keyword that could cause issues in rare circumstances
* Changing internal `_safe_key` logic to be twice as fast
* Removing support for ruamel.yaml < 0.17
@cdgriffith
Copy link
Owner

Box 6 has been released with this added, thanks for opening the issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cdgriffith @ipspace