Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version 4.0.0 #116

Merged
merged 38 commits into from
Dec 25, 2019
Merged

Version 4.0.0 #116

merged 38 commits into from
Dec 25, 2019

Conversation

cdgriffith
Copy link
Owner

@cdgriffith cdgriffith commented Dec 18, 2019 •
edited
Loading

  • Adding support for retrieving items via dot notation in keys
  • Adding box_from_file helper function
  • Adding merge_update that acts like previous Box magic update
  • Adding support to + boxes together
  • Adding default_box now can support expanding on None placeholders (thanks to Harun Tuncay and Jeremiah Lowin)
  • Adding ability to recast specified fields (thanks to Steven McGrath)
  • Adding to_csv and from_csv capability for BoxList objects (thanks to Jiuli Gao)
  • Changing layout of project to be more object specific
  • Changing update to act like normal dict update
  • Changing to 120 line character limit
  • Changing how safe_attr handles unsafe characters
  • Changing all exceptions to be bases of BoxError so can always be caught with that base exception
  • Changing delete to also access converted keys (thanks to iordanivanov)
  • Removing ordered_box as Python 3.6+ is ordered by default
  • Removing BoxObject in favor of it being another module

This will address issues #115 #112 #111 #88 #87 #86 #76 #59 #57 #11

This PR will remain open until minimum of Dec 25th (if all goes perfect, Christmas release!)

Anyone please feel free to test this code and provide feedback!

pip install git+https://github.com/cdgriffith/Box.git@4.0

@cdgriffith cdgriffith added the 4.0 Feature planned for major 4.0 releasee label Dec 18, 2019
@cdgriffith cdgriffith added this to the 4.0 milestone Dec 18, 2019
@pep8speaks
Copy link

pep8speaks commented Dec 18, 2019 •
edited
Loading

Hello @cdgriffith! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-12-24 18:23:40 UTC

cdgriffith and others added 27 commits December 17, 2019 18:36
@cdgriffith
Breaking everything into different files
de03b5f
@cdgriffith
Updating travis info
0745364
@cdgriffith
Removing formats in favor of f-strings
36faa26 
Working tests
Removing Ordered box
Changing to 120 character line limit
@cdgriffith
Update to 3.6+ only
9ba285f
@cdgriffith
Breakout the tests into their own files
ffcc364
@cdgriffith
Add to_toml coverage
309a9d1
@cdgriffith
Remove unneeded safe_key
16953de
@cdgriffith
Adding thanks, history and testimonial readme
8685403 
Bringing in features from development branch
@cdgriffith
Small cleanup
90b993c
@cdgriffith
WIP
3e60c7a
@cdgriffith
Removing wrapt / BoxObject
ac5fa6f 
Removing old performance test
Adding toml Box support
Fixing how attrs are made safe
@cdgriffith
Docs
1b22856
@cdgriffith
Adding recent updates to box and separating merge_update into its own…
8ef7a61 
… function.
@cdgriffith
Adding to_toml for box list
b489c53
@cdgriffith
Removing keyword checking from errors
1007c2e
@haruntuncay @cdgriffith
Solves issue#59 - Treat None values as non-existing keys for default_…
fe05ead 
…box (#108)

* Solves issue#59 - Treat None values as non-existing keys for default_box
@cdgriffith
Adding + support for Box
eec432c 
Adding 4.0 changes
@cdgriffith
Adding new exception types
8ef5b03
@cdgriffith
Fix delete to be able to access converted and camel killed keys (than…
3f17cf6 
…ks to iordanivanov)
@cdgriffith
Better delete behavior and tests for addition of boxes
3ba4092
@cdgriffith
Adding ability to recast certain fields (thanks to Steven McGrath)
92941c3
@cdgriffith
Adding 3.4.6 changes
67cc392
@cdgriffith
Fixing dots to work with setting and deleting attributes
6e25662 
Adding pypy3 to travisCI
setup pytest-runner fix
@cdgriffith
Removing pypy because of pickling issue, adding nightly
f50e88f
@cdgriffith
Adding toml tests
4117bf2
@cdgriffith
Adding box_from_file
d6731a8
@cdgriffith
Test updates
36d906d
@coveralls
Copy link

coveralls commented Dec 18, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.2%) to 99.605% when pulling 607517b on 4.0 into 6d8790e on master.

@cdgriffith cdgriffith merged commit d10fb33 into master Dec 25, 2019
rochacbruno added a commit to dynaconf/dynaconf that referenced this pull request Dec 26, 2019
@rochacbruno
Pin python-box version because of a breaking release
e37af1d 
The release of python-box cdgriffith/Box#116
is a breaking change.

So pinning this until this project addapts.

Also pinning other direct deps.
@rochacbruno rochacbruno mentioned this pull request Dec 26, 2019
Merged
rochacbruno added a commit to dynaconf/dynaconf that referenced this pull request Dec 26, 2019
@rochacbruno
Pin python-box version because of a breaking release
581eb11 
The release of python-box cdgriffith/Box#116
is a breaking change.

So pinning this until this project addapts.

Also pinning other direct deps.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
4.0 Feature planned for major 4.0 releasee
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cdgriffith @pep8speaks @coveralls @haruntuncay