-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug report: first subtitle on the list has default flag set, no option to change this behaviour #129
Comments
Marking this as feature request for now, because this a bug in FFmpeg for MKV containers that I can't control the behavior of. Would either need to have the option to add a fake emtpy first track to make sure that doesn't happen or bring mkvmerge or something else into the mix to handle that after the fact. |
Thanks for such a rapid response! I'm sure ffmpeg must be aware of the bug so hopefully they're working on a fix that'll be out soon. I might see if I can find anything about it in their issue tracker. Perhaps it's fixed for the next release so I could install a dev build or compile ffmpeg myself to fix the issue. If not, mkvmerge would certainly fix it. That's what I'm using to correct the problem myself and it seems like a "cleaner" solution than adding an empty subtitle track. Although I'm sure that would be an effective quick and dirty way to sort it if implementing mkvmerge is a hassle or time consuming to bring another dependency in :) |
Looking at the docs for it: https://ffmpeg.org/ffmpeg.html
I might actually be setting it wrong, because I do |
Well, guess we both have the bugs. Becacuse I was setting wrong track as expected, but still didn't make a difference. Setting to 0 properly shows in ffmpeg that nothing is being set, but still is set to default via MediaInfo.
Setting it to forced or default does show properly in ffmpeg, and is forced in MediaInfo, but still also default.
So as experienced before, there is a bug of some kind with FFmpeg and MKV containers. But I also need to fix how disposition is set per track. |
Looking on the bright side, whenever the ffmpeg bug gets fixed upstream this problem will now for sure disappear from FastFlix! Thanks for looking into this so quickly. |
For anyone looking into this for now, can fix the generated video using mkvtoolnix mkvpropedit from the command line without the need for remuxing.
|
In 4.0 this will be a "hidden" feature, aka will attempt to fix automatically in background after an encoding if |
Perfect, nice clean fix thank you! |
The default flag for subtitles can be disabled with the following ffmpeg command: I found this solution here: I just insert the line under "Custom ffmpeg options", but it would be great if this could be integrated as a selectable option in the FastFlix GUI. |
That is perfect @wiedemanu, thank you! I will look to add that as default behavior when no subtitles tracks are marked as default or forced |
Perfect! Thank you for adding this feature @cdgriffith |
…opedit (thanks to wiedemanu) * Fixing network paths not working on Windows
…opedit (thanks to wiedemanu) * Fixing network paths not working on Windows
* Fixing #129 no subtitles should be enabled, removing need for mkvpropedit (thanks to wiedemanu) * Fixing network paths not working on Windows * Adding support for source_directory and output_name_format in config file (thanks to cwills75) * Changing difference between requirements and requirements-build and removing the build version
* Adding support for source_directory and output_name_format in config file (thanks to cwills75) * Fixing #129 no subtitles should be enabled, removing need for mkvpropedit (thanks to wiedemanu) * Fixing network paths not working on Windows * Changing difference between requirements and requirements-build and removing the build version
Thanks again for that elegant |
Just found this project after trying to transcode some HDR content and learning HB doesn't support it yet.
So far so good with this, it does what it says on the tin and works very well. Thanks for making it!
I do have one small bug report however. In the current stable build, 3.4.3, if I select a subtitle track for an x265 encode it gets set as default in the MKV container. This means when I play the video the subtitles are enabled automatically. Nothing in the UI allows me to toggle this, compared to HB where I can tick a box if I want a subtitle track to be flagged as default... except in Mac OS where funnily enough HB has an identical bug.
Easy to fix this with some quick remuxing but nonetheless it'd be great if you could add a little box the user can select if they want the subtitle to be default or not, or simply change the command passed to x265 to explicitly tell it the subtitle track isn't default so the flag is disabled.
Thanks again for making this useful piece of software.
The text was updated successfully, but these errors were encountered: