Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

With 4.0.1 and encoding with x264 the "Remove HDR" checkbox has no effect #144

Closed
chadj opened this issue Dec 29, 2020 · 2 comments
Closed

With 4.0.1 and encoding with x264 the "Remove HDR" checkbox has no effect #144

chadj opened this issue Dec 29, 2020 · 2 comments
Labels
bug Something isn't working
Projects
FastFlix

Comments

@chadj
Copy link

chadj commented Dec 29, 2020

I'm attempting to encode with x264 while removing HDR in 4.0.1 and the "Remove HDR" checkbox has no effect on the FFmpeg command line that is being generated.

Also, thanks for the amazing software!
cdgriffith added a commit that referenced this issue Dec 29, 2020
@cdgriffith
* Fixing #144 Remove HDR not working (thanks to Chad Johnson)
ed41e85 
* Fixing thumbnail generation preview for videos with arib-std-b67 color transfer
@cdgriffith cdgriffith added the bug Something isn't working label Dec 29, 2020
@cdgriffith
Copy link
Owner

Thanks for the report! Fix in beta https://github.com/cdgriffith/FastFlix/releases/tag/4.0.2b0

@cdgriffith cdgriffith added this to In Staging in FastFlix Dec 30, 2020
@cdgriffith cdgriffith mentioned this issue Dec 30, 2020
Merged
cdgriffith added a commit that referenced this issue Dec 30, 2020
@cdgriffith
Version 4.0.2 (#145)
0f22dc7 
* Fixing #144 Remove HDR not working (thanks to Chad Johnson)
* Fixing #135 color information wasn't passed through correctly (thanks to leonardyan)
* Fixing #143 by adding legacy windows builds with Python 3.8 for time being (thanks to odignal)
* Fixing queue breaks if there is an error during conversion
* Fixing Remove HDR doesn't stay selected when returning item from queue
* Fixing resolution doesn't stay after returning from queue
* Fixing thumbnail generation preview for videos with arib-std-b67 color transfer
@cdgriffith cdgriffith moved this from In Staging to Done in FastFlix Dec 30, 2020
@cdgriffith
Copy link
Owner

Fixed in https://github.com/cdgriffith/FastFlix/releases/tag/4.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
No open projects
FastFlix
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chadj @cdgriffith