Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FastFlix 4.7.1 NVEncC always has a command line: --avsync vfr, Ignores CFR settings #313

Closed
Wontell opened this issue Mar 24, 2022 · 4 comments
Labels
bug Something isn't working enhancement Improve existing feature

Comments

@Wontell
Copy link

Wontell commented Mar 24, 2022

Hi,
Im re-encoding game footage that has variable FPS
FastFlix when used with NVencC ignores the advanced tab settings and always sets --avsync vfr, completely ignoring the setting i chose, 60fps original, 60fps output and CFR.
Raw Command tab always show --avsync vfr, no matter my settings.
It works fine with FFmpeg nvenc option, but its slower

I created a FastFlix preset with my encode settings, all the game footage is from same game, captured by ShadowPlay, Variable FPS, usually hovers around 80, later by the end of the game i capped to 60fps while keeping 120hz, some re-encoded files indeed came out with constant bitrate but most didn't.
I think for the files with 60fps capped variable fpsm FastFlix uses CFR when you enable it in the advanced tab, but files with variable fps that go above 60, FastFlix for some reason always does --avsync vfr.

If anyone have this bug, temporal solution is easy: set all your settings in FastFlix, including the input and output file names.
Go to Raw Command and copy everything to text file.
find where it says --avsync vfr
replace with --avsync forcecfr

Open CMD window and copy paste everything and press enter, it will start rendering in the CMD window

@cdgriffith cdgriffith added bug Something isn't working enhancement Improve existing feature labels Mar 26, 2022
@cdgriffith
Copy link
Owner

Labeling this as bug and enhancement because the "bug" is there is nothing properly saying half the stuff on the advance page doesn't work with the hardware encoders. Nor is there a way to tell what does without deciphering the command yourself.

The enchantment is, just set forcecfr when cfr is selected and vfr if vfr is explicitly set. Otherwise fall back to figuring it out from the input video. Will either add this enhancement first, or both at same time. Thanks for raising the issue!

@Wontell
Copy link
Author

Wontell commented Mar 26, 2022

Labeling this as bug and enhancement because the "bug" is there is nothing properly saying half the stuff on the advance page doesn't work with the hardware encoders. Nor is there a way to tell what does without deciphering the command yourself.

The enchantment is, just set forcecfr when cfr is selected and vfr if vfr is explicitly set. Otherwise fall back to figuring it out from the input video. Will either add this enhancement first, or both at same time. Thanks for raising the issue!

Hi,
NVencC only has 3 FPS modes, cfr, forcecfr and vfr, if you can change the advanced setting for nvencc to just reflect these 3 options it can also be a solution, right now the advanced tab vsync option has more settings then actual encoder.
Unless the advanced settings page is mirrored for all encoders and cant be changed to suit each encoder individually.

Thank you

@cdgriffith
Copy link
Owner

Correct that panel is independent of the encoders / doesn't get info about what encoder is currently selected. It was created back when only FFmpeg was used and these were just filters or stuff we could tack onto FFmpeg itself so it didn't matter.

Best solution would be to make it aware of what encoder is being used and preset only valid options. Will need a stopgap until that can be done. Probably just label the options with a marker beside them of what doesn't work with rigaya's encoders.

cdgriffith added a commit that referenced this issue Mar 26, 2022
…ntell)

* Adding "Auto" profile for VCEncC
* Fixing profile not being passed for AVC with VCEencC and stuck on Baseline
cdgriffith added a commit that referenced this issue Mar 27, 2022
* Adding #313 basic vsync support for hardware encoders (thanks to Wontell)
* Adding #312 additional pixel formats for most encoders (thanks to Owen Quinlan)
* Adding "Auto" profile for VCEncC
* Changing #292 back to PySide2 to be compatible with Windows 7 and 8 (thanks to Causemic)
* Fixing #310 QT was complaining about some PNG formats (thanks to Don Gafford)
* Fixing #315 HDR10 info not parsed from subsequent video tracks than the first (thanks to msaintauret)
* Fixing profile not being passed for AVC with VCEencC and stuck on Baseline
* Fixing that force 10-bit encoding for NVEencC was not set from profiles properly (thanks to wynterca)
@cdgriffith
Copy link
Owner

Adding the ability to set CFR / VFR from vsync drop down for rigaya's encoders in https://github.com/cdgriffith/FastFlix/releases/tag/4.8.0

Also adding note about items not supported at all in advanced panel. Thanks for bringing this up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement Improve existing feature
Projects
None yet
Development

No branches or pull requests

2 participants