Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resize Ignores Custom Resolution #468

Closed
GT500org opened this issue Apr 25, 2023 · 4 comments
Closed

Resize Ignores Custom Resolution #468

GT500org opened this issue Apr 25, 2023 · 4 comments
Labels
bug Something isn't working

Comments

@GT500org
Copy link

FastFlix Version:
5.5.1

Operating System:
Win 10 x64 (22H2)

Describe the bug
When I enter a custom resolution to resize a video, it ignores the resolution I enter manually and keeps the original resolution of the video in the command. After converting the video, no resizing will have taken place. I have verified this with both width:height and just height.

@GT500org GT500org added the bug Something isn't working label Apr 25, 2023
@cdgriffith
Copy link
Owner

Thank you for the information!

Few things that have gone wrong I am addressing in next release:

  1. https://trac.ffmpeg.org/wiki/Scaling some versions of ffmpeg when using filter_complex don't apply the same defaults, aka will always keep aspect ratio the same. Fixing
  2. no trigger to update the command on the page after changing the text on the custom field. Fixing
  3. The thumbnail would ignore custom resolutions. Now will build full size thumbnail if set to a custom resolution.
  4. Fixing large preview wouldn't use the scale

cdgriffith added a commit that referenced this issue Apr 26, 2023
* Adding #469 Romanian translations (thanks to RoDanny2021)
* Fixing #468 Custom resolutions not applying (thanks to GT500org)
@cdgriffith
Copy link
Owner

Hopefully all fixed in 5.5.2 https://github.com/cdgriffith/FastFlix/releases/tag/5.5.2

@GT500org
Copy link
Author

I was able to resize videos without issue (changing the aspect ratio or maintaining it) using custom resolutions in 5.5.2. Thanks for the quick fix.

@cdgriffith
Copy link
Owner

Awesome, thanks for the confirmation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants