You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
When using AVC x264 encoder in 2 pass mode, changing the output frame rate results in error after first pass. To Reproduce
Choose the AVC x264 encoder.
Choose the "Bitrate" mode in the "Quality" tab (This will use the 2 pass encoding method, where the first pass generates a log file and the second pass uses it to closely match the desired bitrate).
In the "Advanced" tab, uncheck the "Same as Source" option to the right of "Output FPS" and then enter fps number into the box to the box. Choose a number different to the source file frame rate.
Start the encoding. Wait until the first pass finishes, right after that the error will happen.
Screenshots
Logs
The problem is that FastFlix applies the -r frame rate option only to the second pass. Here you can see the command FastFlix runs for the first pass:
The bug can be worked around by putting the option -r <desired frame rate> in the "Custom ffmpeg options" box in the "Quality" tab, however that is not ideal since it puts the option twice in the second pass, and in general the frame rate selection field should work without this.
The text was updated successfully, but these errors were encountered:
I think the bug is here, the output_fps information is part of the ending string generated by generate_all function but it is not concatenated to the first pass command.
* Fixing #491 Can't open Setting in Chinese upgraded from old version (thanks to 谈天才)
* Fixing #494 frame rate change in 2 pass mode ("Bitrate" mode) results in error for AVC x264 encoder (thanks to Ivan Gorin)
* Fixing #485 Cannot Restore Queue Containing HDR10+ Entries (thanks to Maddie Davis)
* Fixing #487 Filename corrupted on path change (thanks to Maddie Davis)
* Fixing #491 Can't open Setting in Chinese upgraded from old version (thanks to 谈天才)
* Fixing #493 Profiles did not load config for remove hdr, remove metadata or copy chapter toggles (thanks to micron888)
* Fixing #494 frame rate change in 2 pass mode ("Bitrate" mode) results in error for AVC x264 encoder (thanks to Ivan Gorin)
FastFlix Version: 5,5,5
Operating System: Windows 10
Describe the bug
When using AVC x264 encoder in 2 pass mode, changing the output frame rate results in error after first pass.
To Reproduce
Screenshots
![error](https://private-user-images.githubusercontent.com/43433603/243140989-ddc90b45-82bf-4807-97f8-11fee61bd85c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE1NTkyMTEsIm5iZiI6MTcyMTU1ODkxMSwicGF0aCI6Ii80MzQzMzYwMy8yNDMxNDA5ODktZGRjOTBiNDUtODJiZi00ODA3LTk3ZjgtMTFmZWU2MWJkODVjLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MjElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzIxVDEwNDgzMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTY4M2M5ZjMwODk2ZDIzOWQ1NTEzNTRhMzE1NTRhMDc4NzAwOTA2MDEzZTgxYWNmMjg4ZjY5ZmY3NTBjZTAyODgmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.ojOApQv42jdyPNGCMH34Em5RYlbeAPgsaYuUcVAD9Cg)
Logs
The problem is that FastFlix applies the
-r
frame rate option only to the second pass. Here you can see the command FastFlix runs for the first pass:The bug can be worked around by putting the option
-r <desired frame rate>
in the "Custom ffmpeg options" box in the "Quality" tab, however that is not ideal since it puts the option twice in the second pass, and in general the frame rate selection field should work without this.The text was updated successfully, but these errors were encountered: