Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trying to crop spams crop error #532

Closed
gendalv opened this issue Oct 17, 2023 · 1 comment
Closed

Trying to crop spams crop error #532

gendalv opened this issue Oct 17, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@gendalv
Copy link

gendalv commented Oct 17, 2023 •
edited

FastFlix Version:
5.5.7 portable

Operating System:
Windows 11

Describe the bug
Changing any of the crop numbers on a 2160x3840 video file. Spams like 5 of those messages. (including by pressing 'auto' button)
If crop is non-zero - changing any setting or codec will spam another crop message.
As a result crop isn't applied.

Wasn't an issue in 5.3.0 with the same file.

Screenshots
2
1
@gendalv gendalv added the bug Something isn't working label Oct 17, 2023
@cdgriffith cdgriffith mentioned this issue Nov 5, 2023
Merged
cdgriffith added a commit that referenced this issue Nov 5, 2023
@cdgriffith
* Adding Passes option for bitrate mode in x265 and x264 (thanks to C…
5c787c7 
…hriss)

* Fixing #532 Trying to crop spams crop error (gendalv)
* Removing #525 invalid 12 bit options for x264 (thanks to Chriss)
* Removing #497 #519 advanced checks for hardware encoders, due to them not always being detected (thanks to CptnFluffy)
cdgriffith added a commit that referenced this issue Nov 5, 2023
@cdgriffith
Version 5.6.0 (#524)
8523fcf 
* Adding Passes option for bitrate mode in x265 and x264 (thanks to Chriss)
* Fixing VVC encode options (thanks to Chriss)
* Fixing #532 Trying to crop spams crop error (gendalv)
* Removing distutils in favor of packaging
* Removing #525 invalid 12 bit options for x264 (thanks to Chriss)
* Removing #497 #519 advanced checks for hardware encoders, due to them not always being detected (thanks to CptnFluffy)
@cdgriffith
Copy link
Owner

Changed it in 5.6.0 so instead the colors will just turn red and remove the annoying popups entirely. Thanks for pointing this out!

https://github.com/cdgriffith/FastFlix/releases/tag/5.6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cdgriffith @gendalv