Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EncodingWarning when PYTHONWARNDEFAULTENCODING #60

Closed
jaraco opened this issue Mar 30, 2024 · 2 comments · Fixed by #61
Closed

EncodingWarning when PYTHONWARNDEFAULTENCODING #60

jaraco opened this issue Mar 30, 2024 · 2 comments · Fixed by #61

Comments

@jaraco
Copy link

jaraco commented Mar 30, 2024 

 @ env PYTHONWARNDEFAULTENCODING=1 pip-run puremagic -- -c 'import puremagic'
/var/folders/f2/2plv6q2n7l932m2x004jlw340000gn/T/pip-run-pb4us6gg/puremagic/main.py:76: EncodingWarning: 'encoding' argument not specified
  with open(filename) as f:
@NebularNerd NebularNerd mentioned this issue Mar 31, 2024
Merged
@NebularNerd
Copy link
Contributor

PR submitted to handle this. I'll have to look to add this to my own stuff. 🙂

@cdgriffith cdgriffith mentioned this issue Apr 26, 2024
Merged
cdgriffith added a commit that referenced this issue Apr 26, 2024
@cdgriffith @NebularNerd
Version 1.22 (#62)
4a8a62d 
- Adding #52 magic data for JPEG XS (thanks to Andy - NebularNerd)
- Adding #57 Multi-part checks with negative offsets (thanks to Andy - NebularNerd)
- Fixing #60 encoding warning (thanks to Andy - NebularNerd and Jason R. Coombs)

---------

Co-authored-by: Andy <NebularNerd@users.noreply.github.com>
@cdgriffith
Copy link
Owner

Added in https://github.com/cdgriffith/puremagic/releases/tag/1.22, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update main.py to resolve PYTHONWARNDEFAULTENCODING NebularNerd/puremagic_format_updates
3 participants
@jaraco @cdgriffith @NebularNerd