Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding RFC 5888 update text #63

Merged
merged 2 commits into from Dec 14, 2018
Merged

Adding RFC 5888 update text #63

merged 2 commits into from Dec 14, 2018

Conversation

cdh4u
Copy link
Owner

@cdh4u cdh4u commented Dec 3, 2018

No description provided.

Copy link

@rshpount rshpount left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some editorial issues but this is roughly what I was looking for.

@@ -1845,7 +1849,30 @@ SDP Answer
</section>
</section>

<section anchor="sec-5888" title="Update to RFC 5888" toc="default">
<t>
This section updates RFC 5888 <xref format="default" pageno="false" target="RFC3261"/>),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be a reference to RFC 5888, not 3261,

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will fix.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Section 9.2 (Group Value in Answers) of RFC 5888 is updated.
<section anchor="sec-5888-old-9_2" title="Original text of section 9.2 (3rd paragraph) of RFC 5888" toc="default">
<t>
SIP entities refuse media streams by setting the port to zero in the corresponding
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New and old text are swapped

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will fix.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as well

Copy link

@rshpount rshpount left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The result looks good to me.

@@ -1845,7 +1849,30 @@ SDP Answer
</section>
</section>

<section anchor="sec-5888" title="Update to RFC 5888" toc="default">
<t>
This section updates RFC 5888 <xref format="default" pageno="false" target="RFC3261"/>),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Section 9.2 (Group Value in Answers) of RFC 5888 is updated.
<section anchor="sec-5888-old-9_2" title="Original text of section 9.2 (3rd paragraph) of RFC 5888" toc="default">
<t>
SIP entities refuse media streams by setting the port to zero in the corresponding
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as well

@cdh4u cdh4u merged commit 60a325f into master Dec 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants