Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incompatible with react-app-rewired v2 #14

Closed
alex3683 opened this issue Jan 9, 2019 · 4 comments
Closed

Incompatible with react-app-rewired v2 #14

alex3683 opened this issue Jan 9, 2019 · 4 comments

Comments

@alex3683
Copy link

alex3683 commented Jan 9, 2019

react-app-rewire-hot-loader is incompatible with version 2.x.x of react-app-rewired, since they removed all utility helper functions, including injectBabelPlugin (source: https://github.com/timarney/react-app-rewired/releases/tag/2.0).
Downgrading react-app-rewired isn't an option when working with the most recent version of create-react-app. But it seems as if the react-app-rewired team is aware of this issue: timarney/react-app-rewired#346 (comment)
@ghost
Copy link

ghost commented Jan 11, 2019

Really need to update this package for latest version of react-app-rewired (2.x).

@cdharris
Copy link
Owner

I'm not working on a React project at the moment so would appreciate pull requests for this :)

@cdharris
Copy link
Owner

cdharris commented Feb 6, 2019

This should hopefully be fixed by @Olafaloofian 's PR #16
New v2.0.0 published.

@cdharris
Copy link
Owner

cdharris commented Feb 9, 2019

v2.0.1 published as per #17 that should restore this functionality now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alex3683 @cdharris