Support webpack config factory (CRA v2.1.2) #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If anyone wants to try / preview |
tiffon
added a commit
to jaegertracing/jaeger-ui
that referenced
this pull request
Jan 2, 2019
Requires changes from PR #346 which are published as react-app-rewired@2.0.2-next.0 timarney/react-app-rewired#346
tiffon
added a commit
to jaegertracing/jaeger-ui
that referenced
this pull request
Jan 2, 2019
Requires changes from PR #346 which are published as react-app-rewired@2.0.2-next.0 timarney/react-app-rewired#346 Signed-off-by: Joe Farro <joef@uber.com>
|
Assuming everyone is happy with this... I think when it gets merged we will pull out "The built-in rewirers" as those are broken and release a major version 2.0.0 |
|
@timarney Would be very valuable for us and many to have this properly working again! |
|
@timarney Is the jest babelTransform the only build-in rewire being applied? |
|
I believe so ... the decoratorsPluginPath stuff can all go. |
|
FYI, I have confirmed
|
|
@timarney Are you saying the only the |
|
Let's remove it. |
This was referenced Jan 6, 2019
tiffon
added a commit
to jaegertracing/jaeger-ui
that referenced
this pull request
Jan 6, 2019
Requires changes from PR #346 which are published as react-app-rewired@2.0.2-next.0 timarney/react-app-rewired#346 Signed-off-by: Joe Farro <joef@uber.com>
|
@timarney @tiffon Why don't we need this |
|
We can add that back. |
tiffon
added a commit
to jaegertracing/jaeger-ui
that referenced
this pull request
Jan 9, 2019
* WIP upgrade to create-react-app v2.1.2 Requires changes from PR #346 which are published as react-app-rewired@2.0.2-next.0 timarney/react-app-rewired#346 Signed-off-by: Joe Farro <joef@uber.com> * Use node 8, less liberal browser support, fix test Signed-off-by: Joe Farro <joef@uber.com> * Use eslintrc, fix CI build, fix pre-commit hook Make sure the ./packages/jaeger-ui uses the ./.eslintrc. Make sure all tests are run in pre-commit hook. CRA is now failing builds in CI if there are any webpack build warnings: https://github.com/facebook/create-react-app/blob/73e3d0ebf1f2834e1c8c41d3a25ae5e0e99e6f14/packages/react-scripts/scripts/build.js#L171-L184 Signed-off-by: Joe Farro <joef@uber.com> * Skip react-vis.css format check, fail-fast in CI Signed-off-by: Joe Farro <joef@uber.com> * Don't collect coverage from dev proxy setup Signed-off-by: Joe Farro <joef@uber.com> * Upgrade react-app-rewired to 2.0.1 Avoid issue yarnpkg/yarn#6300 Signed-off-by: Joe Farro <joef@uber.com> * Cleanup npm packages in packages/jaeger-ui Signed-off-by: Joe Farro <joef@uber.com>
everett980
pushed a commit
to everett980/jaeger-ui
that referenced
this pull request
Jan 16, 2019
* WIP upgrade to create-react-app v2.1.2 Requires changes from PR jaegertracing#346 which are published as react-app-rewired@2.0.2-next.0 timarney/react-app-rewired#346 Signed-off-by: Joe Farro <joef@uber.com> * Use node 8, less liberal browser support, fix test Signed-off-by: Joe Farro <joef@uber.com> * Use eslintrc, fix CI build, fix pre-commit hook Make sure the ./packages/jaeger-ui uses the ./.eslintrc. Make sure all tests are run in pre-commit hook. CRA is now failing builds in CI if there are any webpack build warnings: https://github.com/facebook/create-react-app/blob/73e3d0ebf1f2834e1c8c41d3a25ae5e0e99e6f14/packages/react-scripts/scripts/build.js#L171-L184 Signed-off-by: Joe Farro <joef@uber.com> * Skip react-vis.css format check, fail-fast in CI Signed-off-by: Joe Farro <joef@uber.com> * Don't collect coverage from dev proxy setup Signed-off-by: Joe Farro <joef@uber.com> * Upgrade react-app-rewired to 2.0.1 Avoid issue yarnpkg/yarn#6300 Signed-off-by: Joe Farro <joef@uber.com> * Cleanup npm packages in packages/jaeger-ui Signed-off-by: Joe Farro <joef@uber.com> Signed-off-by: Everett Ross <reverett@uber.com>
vvvprabhakar
pushed a commit
to vvvprabhakar/jaeger-ui
that referenced
this pull request
Jul 5, 2021
* WIP upgrade to create-react-app v2.1.2 Requires changes from PR jaegertracing#346 which are published as react-app-rewired@2.0.2-next.0 timarney/react-app-rewired#346 Signed-off-by: Joe Farro <joef@uber.com> * Use node 8, less liberal browser support, fix test Signed-off-by: Joe Farro <joef@uber.com> * Use eslintrc, fix CI build, fix pre-commit hook Make sure the ./packages/jaeger-ui uses the ./.eslintrc. Make sure all tests are run in pre-commit hook. CRA is now failing builds in CI if there are any webpack build warnings: https://github.com/facebook/create-react-app/blob/73e3d0ebf1f2834e1c8c41d3a25ae5e0e99e6f14/packages/react-scripts/scripts/build.js#L171-L184 Signed-off-by: Joe Farro <joef@uber.com> * Skip react-vis.css format check, fail-fast in CI Signed-off-by: Joe Farro <joef@uber.com> * Don't collect coverage from dev proxy setup Signed-off-by: Joe Farro <joef@uber.com> * Upgrade react-app-rewired to 2.0.1 Avoid issue yarnpkg/yarn#6300 Signed-off-by: Joe Farro <joef@uber.com> * Cleanup npm packages in packages/jaeger-ui Signed-off-by: Joe Farro <joef@uber.com> Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
vvvprabhakar
pushed a commit
to vvvprabhakar/jaeger-ui
that referenced
this pull request
Jul 5, 2021
* WIP upgrade to create-react-app v2.1.2 Requires changes from PR jaegertracing#346 which are published as react-app-rewired@2.0.2-next.0 timarney/react-app-rewired#346 Signed-off-by: Joe Farro <joef@uber.com> * Use node 8, less liberal browser support, fix test Signed-off-by: Joe Farro <joef@uber.com> * Use eslintrc, fix CI build, fix pre-commit hook Make sure the ./packages/jaeger-ui uses the ./.eslintrc. Make sure all tests are run in pre-commit hook. CRA is now failing builds in CI if there are any webpack build warnings: https://github.com/facebook/create-react-app/blob/73e3d0ebf1f2834e1c8c41d3a25ae5e0e99e6f14/packages/react-scripts/scripts/build.js#L171-L184 Signed-off-by: Joe Farro <joef@uber.com> * Skip react-vis.css format check, fail-fast in CI Signed-off-by: Joe Farro <joef@uber.com> * Don't collect coverage from dev proxy setup Signed-off-by: Joe Farro <joef@uber.com> * Upgrade react-app-rewired to 2.0.1 Avoid issue yarnpkg/yarn#6300 Signed-off-by: Joe Farro <joef@uber.com> * Cleanup npm packages in packages/jaeger-ui Signed-off-by: Joe Farro <joef@uber.com> Signed-off-by: Everett Ross <reverett@uber.com> Signed-off-by: vvvprabhakar <vvvprabhakar@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #343.
Builds on #344.
Ran into problems with this and had to fix it. #344 was close but didn't quite work because of parens and ternary.
CRA uses node >= 6, so template strings and destructuring should be ok.
There is a lot of overlap between
scripts/startandscripts/build. I thought about merging them, but figured best to keep it simple.