CDITCK-551 add test for ProcessSynthethicObserverMethod. #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tremes
reviewed
Dec 15, 2016
| public void syntheticEventInvokedAndReturningSourceTest() { | ||
| assertTrue(extension.timesInvoked() == 3); | ||
| Map<Type, Extension> map = extension.getSources(); | ||
| assertTrue(map.get(Peach.class) instanceof ProcessSyntheticObserverMethodObserver); |
There was a problem hiding this comment.
I would use assertEquals comparing Class of given extension.
tremes
reviewed
Dec 15, 2016
| @SpecAssertions({@SpecAssertion(section = PROCESS_OBSERVER_METHOD, id = "aab"), | ||
| @SpecAssertion(section = PROCESS_OBSERVER_METHOD, id = "dae")}) | ||
| public void syntheticEventInvokedAndReturningSourceTest() { | ||
| assertTrue(extension.timesInvoked() == 3); |
There was a problem hiding this comment.
Use assertEquals as well please. It's more informative when the test fails
|
Otherwise it's good. |
|
Rebased onto master and incorporated requested changes. |
|
Merged. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that the build here will fail as
ProcessSyntheticObserverMethodwas added after CDI Alpha6 release.