CDITCK-549 add test for extension registering custom OM which does no… #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manovotn
commented
Dec 14, 2016
| @SpecAssertions({ @SpecAssertion(section = AFTER_BEAN_DISCOVERY, id = "ec") }) | ||
| public void observerMethodNotOverridingNotifyMethodTreatedAsDefinitionError() { | ||
| deployer.deploy(CONFIGURATOR); |
There was a problem hiding this comment.
@tremes not sure about this - do I need to call undeploy here? Since The deploy itself should not succeed I would guess not...
There was a problem hiding this comment.
I can see compilation problem for ExtensionAddingCustomObserver but to your question - well maybe it would be safer to wrap this to try/catch block and do undeploy in the case of test failure (deployment will pass). This would also mean you can remove @ShouldThrowException.
There was a problem hiding this comment.
Uh true, forgot to add refactoring onto the commit, sorry.
Will fix this and change the test accordingly.
…t override notify method.
|
Merged. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…t override notify method.