CDI-664 Rename/clarify purpose of few SeContainerInitializere methods #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manovotn
reviewed
Dec 8, 2016
| * `enableInterceptors()` adds interceptoror classes to the list of enabled interceptors for the synthetic bean archive. | ||
| * `enableDecorators()` adds decorator classes to the list of enabled decorators for the synthetic bean archive. | ||
| * `selectAlternatives()` adds alternatives classes to the list of selected alternatives for the synthetic bean archive. | ||
| * `selectAlternativeStereotypes()` alternative stereotype classes to the list of selected alternative stereotypes for the synthetic bean archive. |
There was a problem hiding this comment.
Good catch again!! ;-)
tremes
reviewed
Dec 8, 2016
|
|
||
| /** | ||
| * Add decorators for the synthetic bean archive. Decorator classes are automatically added to the set of bean classes for the synthetic bean archive. | ||
| * Add decorator classes to the list of enabled decorators for the synthetic bean archive. |
There was a problem hiding this comment.
I would add This method does not add any class to the set of bean classes of the synthetic bean archive. here as well
There was a problem hiding this comment.
Makes sense. Will add this to "alternatives" methods as well.
|
I think it's ok now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.