Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pathParams #233

Closed
mathewmeconry opened this issue Feb 14, 2020 · 2 comments · Fixed by #234
Closed

pathParams #233

mathewmeconry opened this issue Feb 14, 2020 · 2 comments · Fixed by #234

Comments

@mathewmeconry
Copy link
Contributor

This typing has from my point of view the wrong type assigned:

pathParams: string[];

should be

pathParams: { [index: string]: string };

during debugging the pathParams is an object:
image

File where I found it:

express-openapi-validator/src/framework/types.ts

Line 401 in 461e960

pathParams: string[];

I'm happy to open a pull request if you accept this as an issue.
@cdimascio
Copy link
Owner

@mathewmeconry thanks. i think you're right. please open a PR. thanks a lot!

mathewmeconry added a commit to mathewmeconry/express-openapi-validator that referenced this issue Feb 14, 2020
@mathewmeconry
fixes pathParams typing in OpenApiRequestMetadata
8c5b574 
resolves cdimascio#233
@mathewmeconry mathewmeconry mentioned this issue Feb 14, 2020
Merged
@mathewmeconry
Copy link
Contributor Author

@cdimascio here you go :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixes pathParams typing in OpenApiRequestMetadata mathewmeconry/express-openapi-validator
2 participants
@mathewmeconry @cdimascio