Request validator middleware throws for valid requests (query parsing)

[dystopiandev]

Describe the bug
I use swagger-routes-express to parse and mount OAS3 paths as express routes. I mount the routes after using:

middleware({
  apiSpec: (validatedDefinition as unknown) as string,
  validateRequests: { allowUnknownQueryParameters: false },
  validateResponses: true,
  validateFormats: "full",
  $refParser: { mode: "dereference" },
  validateSecurity: true,
  operationHandlers: false
})

...but I get errors on all routes, whether or not they require any params.

Actual behavior
Throws Bad Request: request should have required property 'query'

Expected behavior
Shouldn't throw, because all is right by the spec.

I solved it temporarily by changing:

const valid = validator(Object.assign(Object.assign({}, req), { cookies }));

...to:

const valid = validator(Object.assign(Object.assign({query: {}}, req), { cookies }));

...in node_modules/express-openapi-validator/dist/middlewares/openapi.request.validator.js

...so I reckon changing this line to

const valid = validator({ query: {}, ...req, cookies });

...should resolve this.

[cdimascio]

@dystopiandev interesting. this almost seems as if some middleware in the stack is nulling out the req.query. typically, its {} when not present. would you be willing to submit a PR with your proposed change? if so, check out CONTRIBUTING.md to get started

[dystopiandev]

@dystopiandev interesting. this almost seems as if some middleware in the stack is nulling out the req.query. typically, its {} when not present. would you be willing to submit a PR with your proposed change? if so, check out CONTRIBUTING.md to get started

I'll send a PR shortly.

[dystopiandev]

@cdimascio #371