WIP: create test for request.query.settings should be object #125 #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cdimascio Sorry I just saw this and was quite busy recently. Would like to tackle this in case nobody else is not already on this. Have more time available starting this afternoon! |
|
@comino no problem. this is all yours. feel free to tackle it. if you have questions or want to discussion feel free to use our gitter channel. thanks for your help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR demonstrates one of the issues @jy95 depicts in #125.
@comino i know that you were looking to get more involved in the project. if you would like to tackle this, please let me know. this is certainly an important enhancement as it closes a gap in our oas3 support