Only enforce query object parsing when specified, always validate #186 #187
Conversation
|
Ah looks like Travis does the linting |
Linter wanted a comma, but that seemed wrong... As that implies function takes another argument. This should appease the linter gods.
This reverts commit 7adaf2e.
|
I'm stumped on the linting... I can't figure out the run-local command so I don't pollute this PR with attempts. In the last commit I was trying to replicate this test's usage of response.body: https://github.com/cdimascio/express-openapi-validator/blob/master/test/response.validation.spec.ts#L88 |
This reverts commit d744985.
|
Apologies for the linter noise, I can re-open a PR/force squash those commits to clean it up if necessary |
| const schemaHasObject = schema => { | ||
| return ( | ||
| schema.type === 'object' && | ||
| schema.type !== 'array' |
There was a problem hiding this comment.
This was copy+paste... but realistically is unnecessary (tautology)
in terms of linting. i use prettier to autoformat the code. |
|
@all-contributors add @JacobLey for code and test |
|
I've put up a pull request to add @JacobLey! 🎉 |
From discussion in this PR: cdimascio#187 (comment)
This updated test+parsing highlights when forced JSON.parsing is not appropriate, and should rely on validator to determine success.
Opened as an attempt to solve this issue: #186
I tried my best to match existing code style, but wasn't sure if there was an official linter command/test. If so that has not been run but I am happy to tweak if necessary.