Move @types/multer to dependencies #401
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types from
@types/multer
are being used in the exportedframework/types.d.ts
file. This breaks the TypeScript build of any project that uses this library but doesn't have@types/multer
installed. Multer isn't a peerDependency of this library, so it shouldn't be a requirement for projects using express-openapi-validator to install it separately. It should be included as a dependency, and not a devDependency.There could potentially be an issue with
@types/express
being used inframework/types.d.ts
as well, but it's likely that any TypeScript project using this library will already have express types installed separately.