Fix: electron asar - failed to open spec dir #531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For electron-based apps, it is not possible to change the current working directory as all source is packaged within an asar. Therefore, we suggest to remove these calls.
|
@phpfs yes. it appears we no longer need to change dir. cool! thanks for this |
|
one minor nit, please remove the empty finally block. once in, i'll get this merged in and a new version rolled out asap |
cdimascio
reviewed
Feb 3, 2021
|
nevermind ;) i cleaned it up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to resolve the issue described in ticket #530 "electron asar - failed to open spec dir".
Although the removed statements seem to have had intention, their absence does not cause any issue with the current mocha test suite. Locally, the PR runs with 337 test passed and 4 pending - exactly like beforehand. To me it makes sense that the code works without these statements since actual reading takes place using the absolute path only.
It remains to be discussed wether this is a proper fix for the issue (or just a workaround) and if this may cause issues for some users.
Thank you very much @cdimascio for your help :)