fix: Relax Allow Header Test #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: The test asserted the order of methods in the Allow header. The order is irrelevant for the header and not guaranteed by the code, so that the test failed using Node 10. Solution: Adjust the assertion to check the returned methods irrespective of order.
cdimascio
approved these changes
Mar 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bad test in #560. Tested with Node 10 and Node 15.
Problem: The test asserted the order of methods in the Allow header. The order is irrelevant for the header and not guaranteed by the code, so that the test failed using Node 10.
Solution: Adjust the assertion to check the returned methods irrespective of order.