Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add go.mod #25

Merged
merged 2 commits into from
Jul 15, 2022
Merged

Add go.mod #25

merged 2 commits into from
Jul 15, 2022

Conversation

ashnair1
Copy link
Contributor

@ashnair1 ashnair1 commented Jul 24, 2021 •
edited
Loading

Thought I'd add this to make the project compatible with go modules. This fixes an issue with build where go get fails. Now the build should (in theory) only fail if tests don't pass.

@ashnair1
Copy link
Contributor Author

ashnair1 commented Oct 30, 2021 •
edited
Loading

Ran go mod tidy -go=1.17 for 1.17 compatibility
Ref: https://golang.org/doc/go1.17#go-command

@ashnair1
Copy link
Contributor Author

Pinging @piazzamp

piazzamp
piazzamp approved these changes Jul 15, 2022
View reviewed changes
Copy link
Collaborator

@piazzamp piazzamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for the delay! thanks for helping make the project more usable 😄

@piazzamp piazzamp merged commit cd90bdf into cdipaolo:master Jul 15, 2022
@ashnair1 ashnair1 deleted the gomod branch July 15, 2022 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piazzamp piazzamp piazzamp approved these changes

@ubaidh ubaidh ubaidh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ashnair1 @piazzamp @ubaidh