Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate the redirect source(s) in bin/ before instantiating the stack #2

Open
douglasnaphas opened this issue Oct 13, 2021 · 2 comments
Open

Validate the redirect source(s) in bin/ before instantiating the stack #2

douglasnaphas opened this issue Oct 13, 2021 · 2 comments
Projects
sredirect-v1

Comments

@douglasnaphas
Copy link
Contributor

No description provided.

@douglasnaphas douglasnaphas created this issue from a note in sredirect-v1 (To do) Oct 13, 2021
@douglasnaphas douglasnaphas changed the title Validate the redirect target in bin/ before instantiating the stack Validate the redirect source(s) in bin/ before instantiating the stack Oct 13, 2021
@douglasnaphas
Copy link
Contributor Author

I actually don't think I need extensive validation of the account's rights over the source domain, because if the account doesn't have them, stack deployment will fail when we can't get a cert.

@douglasnaphas
Copy link
Contributor Author

Note: when you create a hosted zone for a name you don't own, AWS creates a delegation set of name servers associated with that hosted zone. I proved this out in my lab2 account.

douglasnaphas added a commit that referenced this issue Feb 5, 2022
@douglasnaphas
Set up a Redirects type
2154f54 
gh-2
douglasnaphas added a commit that referenced this issue Feb 5, 2022
@douglasnaphas
Try to validate the redirects
f41cc34 
gh-2
douglasnaphas added a commit that referenced this issue Feb 5, 2022
@douglasnaphas
Log typeof appProps.redirects
7ff662c 
gh-2

I am losing track of what type my various objects representing the input
params are.
douglasnaphas added a commit that referenced this issue Feb 5, 2022
@douglasnaphas
Use a Redirect validation function
11accb4 
gh-2
douglasnaphas added a commit that referenced this issue Feb 6, 2022
@douglasnaphas
Insist on a RedirectType
6750376 
gh-2
douglasnaphas added a commit that referenced this issue Feb 6, 2022
@douglasnaphas
Actually fail if the Redirect type is invalid
ec22c8b 
gh-2
douglasnaphas added a commit that referenced this issue Feb 6, 2022
@douglasnaphas
Use shorter names for RedirectTypes
45ad489 
gh-2

SSM Params have a size limit of 4096 bytes each. I might switch to
having one param per redirect or HTTP origin for this reason.
douglasnaphas added a commit that referenced this issue Feb 6, 2022
@douglasnaphas
Make actual Redirects, not conforming objects
6adf59b 
gh-2
douglasnaphas added a commit that referenced this issue Feb 6, 2022
@douglasnaphas
Take RedirectType in the Redirect constructor
ad358cb 
gh-2

I'm going to do both 302s and fronting of HTTP Origins.
douglasnaphas added a commit that referenced this issue Feb 6, 2022
@douglasnaphas
Set up tests for requiredCerts
d3bd188 
gh-2

This includes a pretty infuriating issue relating to "const enum" vs
"enum." I got an error:

TypeError: Cannot read properties of undefined (reading 'FOUND')

before I changed `export enum` to `export const enum`, which is
seriously confusing.

https://stackoverflow.com/questions/50365598/typescript-runtime-error-cannot-read-property-of-undefined-enum
douglasnaphas added a commit that referenced this issue Feb 6, 2022
@douglasnaphas
Put RedirectType in its own file
c36f304 
gh-2

so I can use a classic, not a const, enum.

https://stackoverflow.com/a/62564232/2260686

https://stackoverflow.com/a/53232849/2260686

https://www.typescriptlang.org/docs/handbook/enums.html#const-enum-pitfalls
douglasnaphas added a commit that referenced this issue Feb 7, 2022
@douglasnaphas
Implement requiredCerts()
2c55dce 
gh-2
douglasnaphas added a commit that referenced this issue Feb 7, 2022
@douglasnaphas
Remove unnecessary re-ordering in sort function
6af1606 
gh-2
douglasnaphas added a commit that referenced this issue Feb 7, 2022
@douglasnaphas
Sort in lex order, stars last
9669da3 
gh-2
douglasnaphas added a commit that referenced this issue Feb 7, 2022
@douglasnaphas
Sort within the set of * domains
efa2917 
gh-2
douglasnaphas added a commit that referenced this issue Feb 7, 2022
@douglasnaphas
Test cases with several levels of DNS names
e9fad3f 
gh-2
douglasnaphas added a commit that referenced this issue Feb 7, 2022
@douglasnaphas
Try to deploy a cert, associated with the distro
3135f4a 
gh-2
douglasnaphas added a commit that referenced this issue Feb 9, 2022
@douglasnaphas
Use URL for to and from
207b3c9 
gh-2

Same fix as
DefinitelyTyped/DefinitelyTyped#19799 (comment)
was part of this..
douglasnaphas added a commit that referenced this issue Feb 9, 2022
@douglasnaphas
Instantiate URLs for to and from in bin
d77db4e 
gh-2

I want type errors, which here I mean to include "that's a URL with no
scheme," to fail in bin, not lib. My last build, which ran with a
from-value with no scheme (like "https://") failed in lib.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
sredirect-v1
To do
Milestone
No milestone
Development

No branches or pull requests
1 participant
@douglasnaphas