Added PMD tests for detecting misuse of TestClass and TestMethod, e.g…

…. TestClass on a method. (fixes #3014808)
cdk · Jun 17, 2010 · c94ebcf · c94ebcf
1 parent 9d679fe
commit c94ebcf
Showing 1 changed file with 38 additions and 0 deletions.
diff --git a/pmd/customCDK.xml b/pmd/customCDK.xml
@@ -24,6 +24,44 @@
     </properties>
   </rule>
 
+  <rule name="TestClassAnnotationForMethod"
+        message="Methods should be annotated with TestMethod, not TestClass."
+        class="net.sourceforge.pmd.rules.XPathRule">
+    <description>
+      Detects methods annotated with @TestClass, where @TestMethod is supposed
+      to be used.
+    </description>
+    <priority>1</priority>
+    <properties>
+      <property name="xpath" pluginname="true">
+        <value>
+          <![CDATA[
+//ClassOrInterfaceBodyDeclaration[count(Annotation//Name[@Image='TestClass'])=1]
+          ]]>
+        </value>
+        </property>
+    </properties>
+  </rule>
+
+  <rule name="TestMethodAnnotationForClass"
+        message="Classes should be annotated with TestClass, not TestMethod."
+        class="net.sourceforge.pmd.rules.XPathRule">
+    <description>
+      Detects classes annotated with @TestMethod, where @TestClass is supposed
+      to be used.
+    </description>
+    <priority>1</priority>
+    <properties>
+      <property name="xpath" pluginname="true">
+        <value>
+          <![CDATA[
+//ClassOrInterfaceBodyDeclaration[count(Annotation//Name[@Image='TestClass'])=1]
+          ]]>
+        </value>
+        </property>
+    </properties>
+  </rule>
+
   <!-- does not work yet... needs to be fixed
   
    rule name="CDK_MoreThanOneLoggingToolInstantiated"