fix(import): cannot import props that have non-standard capitalization #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
json2jsii now emits `toJson()` functions for all generated structs which can be used to convert data back to the original schema. This means that we can now import APIs and CRDs even if their property names are not properly camel cased, use underscores or hyphens, etc. Improve test harness to also take a snapshot of the generated typescript output
eladb
commented
Jul 21, 2021
|
|
||
| expect(manifest).toMatchSnapshot(); | ||
| const languages = [Language.TYPESCRIPT]; |
There was a problem hiding this comment.
For now, just typescript - otherwise it takes forever and forever
iliapolo
approved these changes
Jul 21, 2021
|
Build error was just a transient dependency issue (I noticed the exact same build error preventing a upgrade-deps PR from being merged yesterday). |
Thanks for following up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
json2jsii now emits
toJson()functions for all generatedstructs which can be used to convert data back to the original
schema.
This means that we can now import APIs and CRDs even if their
property names are not properly camel cased, use underscores
or hyphens, etc.
Improve test harness to also take a snapshot of the generated typescript
output