Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Container resource requirements and HPA #27

Closed
2 tasks done
Tracked by #379
foriequal0 opened this issue Dec 10, 2020 · 8 comments · Fixed by #390
Closed
2 tasks done
Tracked by #379

Container resource requirements and HPA #27

foriequal0 opened this issue Dec 10, 2020 · 8 comments · Fixed by #390
Assignees
Labels
effort/small 1 day tops feature-request New/Enhanced functionality wanted priority/p1 Should be on near term plans

Comments

@foriequal0
Copy link

Description of the feature or enhancement:

Containers can set their resource limits/requests.

Use Case:

Horizontal Pod Autoscaler requirs containers to set resource requirements.

Proposed Solution:

const container = deployment.addContainer({
 resources: {
   cpu: {
     request: Cpu.millis(100),
     limit: Cpu.units(0.5),
   }
 }
});
container.resources.memory.request = Size.mebibytes(100);
container.resources.memory.limit = Size.gibibytes(1);
// optional? 
container.resources.setHugepage("2Mi", {
  ...
})

Other:

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request

@iliapolo iliapolo transferred this issue from cdk8s-team/cdk8s Jul 6, 2021
@iliapolo iliapolo changed the title [cdk8s+] Container resource requirements and HPA Container resource requirements and HPA Jul 18, 2021
@github-actions
Copy link

This issue is now marked as stale because it hasn't seen activity for a while. Add a comment or it will be closed soon.

@github-actions
Copy link

Closing this issue as it hasn't seen activity for a while. Please add a comment @mentioning a maintainer to reopen.

@iliapolo iliapolo reopened this Sep 27, 2021
@iliapolo iliapolo transferred this issue from cdk8s-team/cdk8s-plus-17 Sep 27, 2021
@iliapolo iliapolo added the needs-triage Priority and effort undetermined yet label Oct 22, 2021
@github-actions
Copy link

This issue is now marked as stale because it hasn't seen activity for a while. Add a comment or it will be closed soon.

@github-actions github-actions bot added the stale label Dec 23, 2021
@akefirad
Copy link

Any update here? Thanks.

@iliapolo iliapolo added effort/medium 1 week tops enhancement and removed needs-triage Priority and effort undetermined yet stale labels Dec 28, 2021
@iliapolo iliapolo removed their assignment Dec 28, 2021
@iliapolo
Copy link
Member

@akefirad We are not currently working on this. Would you be interested in contributing?

@akefirad
Copy link

Sure, but I would probably need help, since I'm not familiar with the internal of the library.

@iliapolo
Copy link
Member

iliapolo commented Jan 3, 2022

You'll want to start with adding the resources property to the container interface here and just look at how other properties are propagated onwards.

Hopefully the relevant code is clear enough, but let us know if you have some specific questions.

Thanks!

@github-actions
Copy link

github-actions bot commented Mar 5, 2022

This issue is now marked as stale because it hasn't seen activity for a while. Add a comment or it will be closed soon. If you wish to exclude this issue from being marked as stale, add the "backlog" label.

@github-actions github-actions bot added the stale label Mar 5, 2022
@iliapolo iliapolo added this to To do in Release Candidate | cdk8s-plus via automation Mar 7, 2022
@iliapolo iliapolo added feature-request New/Enhanced functionality wanted effort/small 1 day tops and removed enhancement effort/medium 1 week tops labels Mar 7, 2022
@iliapolo iliapolo added the priority/p1 Should be on near term plans label Mar 7, 2022
@mergify mergify bot closed this as completed in #390 Mar 8, 2022
Release Candidate | cdk8s-plus automation moved this from To do to Done Mar 8, 2022
mergify bot pushed a commit that referenced this issue Mar 8, 2022
Allow setting compute resources (CPU and memory requests and limits) required by the container.

Signed-off-by: Mac Atre <mac.atre@gmail.com>

Fixes #27
@iliapolo iliapolo self-assigned this Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort/small 1 day tops feature-request New/Enhanced functionality wanted priority/p1 Should be on near term plans
Projects
No open projects
3 participants