New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create probes that check if a TCP socket can be connected to #345

Closed

Tracked by

Chriscbr opened this issue Feb 24, 2022 · 0 comments · Fixed by #383

Closed

Tracked by

Create probes that check if a TCP socket can be connected to #345

Chriscbr opened this issue Feb 24, 2022 · 0 comments · Fixed by #383

Labels

Contributor

Chriscbr commented Feb 24, 2022

https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes/#define-a-tcp-liveness-probe

Chriscbr added the effort/small label

This was referenced Feb 24, 2022

[Tracking Issue] L2 coverage #379

Open

feat: TCP socket probes #383

Merged

mergify bot closed this as completed in #383

mergify bot pushed a commit that referenced this issue


          feat: TCP socket probes (#383)

129d39f

API written based on the documentation here:
- https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-startup-probes/#define-a-tcp-liveness-probe
- https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.23/#probe-v1-core

I think the default behavior in most cases is to connect to `container.port`, so there are no required arguments for `Probe.fromTcpSocket()`, unlike `Probe.fromCommand()` and `Probe.fromHttpGet()`.

Signed-off-by: Christopher Rybicki <rybickic@amazon.com>

Fixes #345

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment