feat(deployment): upgrade strategy #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: github-actions <github-actions@github.com>
Chriscbr
approved these changes
Apr 4, 2022
|
|
||
| const spec: k8s.DeploymentSpec = Testing.synth(chart)[0].spec; | ||
|
|
||
| expect(deployment.strategy).toEqual(DeploymentStrategy.rollingUpdate()); |
There was a problem hiding this comment.
I'm surprised this object equality works (I expected you'd have to call _toKube() on each?)
Signed-off-by: Christopher Rybicki <rybickic@amazon.com>
Chriscbr
force-pushed
the
epolon/deployment-strategy
branch
from
c86579b
to
5e2978f
Compare
Signed-off-by: github-actions <github-actions@github.com>
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
iliapolo
added a commit
that referenced
this pull request
Apr 14, 2022
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #365