Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(stateful-set): update strategy #523

Merged
merged 3 commits into from
Apr 4, 2022

Conversation

iliapolo
Copy link
Member

@iliapolo iliapolo commented Apr 4, 2022

Resolves #372

Signed-off-by: iliapolo <epolon@amazon.com>
@iliapolo iliapolo requested a review from a team April 4, 2022 09:29
@iliapolo iliapolo self-assigned this Apr 4, 2022
Signed-off-by: github-actions <github-actions@github.com>
@@ -57,6 +57,13 @@ export interface StatefulSetProps extends ResourceProps, PodTemplateProps {
* @default PodManagementPolicy.ORDERED_READY
*/
readonly podManagementPolicy?: PodManagementPolicy;

/**
* Indicates the StatefulSetUpdateStrategy that will be employed to update Pods in the StatefulSet when a revision is made to Template.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:

Suggested change
* Indicates the StatefulSetUpdateStrategy that will be employed to update Pods in the StatefulSet when a revision is made to Template.
* Indicates the strategy that will be employed to update Pods in the StatefulSet when a revision is made to Template.

@mergify mergify bot merged commit e47888d into k8s-22/main Apr 4, 2022
@mergify mergify bot deleted the epolon/stateful-set-update-strategy branch April 4, 2022 20:38
@cdk8s-automation
Copy link
Contributor

The backport to k8s-21/main failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-k8s-21/main k8s-21/main
# Navigate to the new working tree
cd .worktrees/backport-k8s-21/main
# Create a new branch
git switch --create backport-523-to-k8s-21/main
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 e47888d8cb93def41bab170dd001efe5282b7e82
# Push it to GitHub
git push --set-upstream origin backport-523-to-k8s-21/main
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-k8s-21/main

Then, create a pull request where the base branch is k8s-21/main and the compare/head branch is backport-523-to-k8s-21/main.

@cdk8s-automation
Copy link
Contributor

The backport to k8s-20/main failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-k8s-20/main k8s-20/main
# Navigate to the new working tree
cd .worktrees/backport-k8s-20/main
# Create a new branch
git switch --create backport-523-to-k8s-20/main
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 e47888d8cb93def41bab170dd001efe5282b7e82
# Push it to GitHub
git push --set-upstream origin backport-523-to-k8s-20/main
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-k8s-20/main

Then, create a pull request where the base branch is k8s-20/main and the compare/head branch is backport-523-to-k8s-20/main.

iliapolo added a commit that referenced this pull request Apr 14, 2022
Resolves #372

(cherry picked from commit e47888d)
Signed-off-by: Eli Polonsky <epolon@amazon.com>
@iliapolo
Copy link
Member Author

💚 All backports created successfully

Status Branch Result
k8s-21/main

Questions ?

Please refer to the Backport tool documentation

iliapolo added a commit that referenced this pull request Apr 14, 2022
Resolves #372

(cherry picked from commit e47888d)
Signed-off-by: Eli Polonsky <epolon@amazon.com>
@iliapolo
Copy link
Member Author

💚 All backports created successfully

Status Branch Result
k8s-20/main

Questions ?

Please refer to the Backport tool documentation

iliapolo added a commit that referenced this pull request Apr 14, 2022
* feat(stateful-set): update strategy (#523)

Resolves #372

(cherry picked from commit e47888d)
Signed-off-by: Eli Polonsky <epolon@amazon.com>

* chore: self mutation

Signed-off-by: github-actions <github-actions@github.com>

Co-authored-by: github-actions <github-actions@github.com>
iliapolo added a commit that referenced this pull request Apr 14, 2022
* feat(stateful-set): update strategy (#523)

Resolves #372

(cherry picked from commit e47888d)
Signed-off-by: Eli Polonsky <epolon@amazon.com>

* chore: self mutation

Signed-off-by: github-actions <github-actions@github.com>

Co-authored-by: github-actions <github-actions@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Specify StatefulSet update strategies
3 participants