chore: use cdklabs-projen-project-types #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are standardizing repository setups to improve maintainability. If you have any questions regarding this change, please reach out to us.
kaizencc
reviewed
Jun 14, 2023
There was a problem hiding this comment.
In addition we need to either 1) click a button in the settings to allow auto merge or 2) set up the automation in cdk-ops to do this for us. @comcalvi may have already started work on a projen task that can configure repository settings.
I have started clicking these buttons manually. Also need to enable the merge queue via ops me thinks. |
mrgrain
commented
Jun 14, 2023
Comment on lines
-11
to
-15
| autoApproveOptions: { | ||
| allowedUsernames: ['cdklabs-automation'], | ||
| secret: 'GITHUB_TOKEN', | ||
| }, | ||
| autoApproveUpgrades: true, |
There was a problem hiding this comment.
These are also not needed.
kaizencc
approved these changes
Jun 14, 2023
kaizencc
deleted the
mrgrain/chore/cdklabs-project-types-2-cdklabs-cdk-cloudformation-OHaOiR
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are standardizing repository setups to improve maintainability.
If you have any questions regarding this change, please reach out to us.