chore: only attempt to release registry modules if they have actual changes #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rix0rrr
approved these changes
Jan 19, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to an unknown Git error
mrgrain
added a commit
that referenced
this pull request
Jan 19, 2024
We need to look for the releasetag.txt file in the right directory.
mrgrain
added a commit
that referenced
this pull request
Jan 19, 2024
- `TAG=cat $(dist/releasetag.txt)` => `TAG=$(cat dist/releasetag.txt)` - Make artifact easier to debug - upgrade `cdklabs-projen-project-types` to unbreak the meta release workflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the workflows in this repo attempted to release every registry module on every change. Despite the fact that the modules are versioned by an external system and don't change that often.
This PR introduced two additional checks before we attempt to release a package:
This should stop most release attempts we are currently making.
Once this has proven successful, we can re-enable the currently disabled Maven releases.
Fixes #376