New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(redshift, rds): alarm on min/max connection count and long query duration #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 30, 2022
echeung-amzn
reviewed
Oct 3, 2022
Signed-off-by: github-actions <github-actions@github.com>
echeung-amzn
changed the title
feat(redshift): add alarms requested by customer
feat(redshift): alarm on min/max connection count and long query duration
Oct 4, 2022
echeung-amzn
changed the title
feat(redshift): alarm on min/max connection count and long query duration
feat(redshift, rds): alarm on min/max connection count and long query duration
Oct 4, 2022
echeung-amzn
requested changes
Oct 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor wording edits, but otherwise LGTM.
Co-authored-by: Eugene Cheung <81188333+echeung-amzn@users.noreply.github.com>
Co-authored-by: Eugene Cheung <81188333+echeung-amzn@users.noreply.github.com>
Co-authored-by: Eugene Cheung <81188333+echeung-amzn@users.noreply.github.com>
Co-authored-by: Eugene Cheung <81188333+echeung-amzn@users.noreply.github.com>
Signed-off-by: github-actions <github-actions@github.com>
echeung-amzn
approved these changes
Oct 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds alarm for min/max connection count and for long query duration.
Closes #248
Closes #249
Closes #232
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license