Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(redshift, rds): alarm on min/max connection count and long query duration #251

Merged
merged 8 commits into from Oct 6, 2022

Conversation

voho
Copy link
Contributor

@voho voho commented Sep 30, 2022

Adds alarm for min/max connection count and for long query duration.

Closes #248
Closes #249
Closes #232


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Signed-off-by: github-actions <github-actions@github.com>
@echeung-amzn echeung-amzn changed the title feat(redshift): add alarms requested by customer feat(redshift): alarm on min/max connection count and long query duration Oct 4, 2022
@echeung-amzn echeung-amzn changed the title feat(redshift): alarm on min/max connection count and long query duration feat(redshift, rds): alarm on min/max connection count and long query duration Oct 4, 2022
Copy link
Member

@echeung-amzn echeung-amzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor wording edits, but otherwise LGTM.

lib/common/monitoring/alarms/ConnectionAlarmFactory.ts Outdated Show resolved Hide resolved
lib/common/monitoring/alarms/ConnectionAlarmFactory.ts Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
voho and others added 5 commits October 6, 2022 14:29
Co-authored-by: Eugene Cheung <81188333+echeung-amzn@users.noreply.github.com>
Co-authored-by: Eugene Cheung <81188333+echeung-amzn@users.noreply.github.com>
Co-authored-by: Eugene Cheung <81188333+echeung-amzn@users.noreply.github.com>
Co-authored-by: Eugene Cheung <81188333+echeung-amzn@users.noreply.github.com>
Signed-off-by: github-actions <github-actions@github.com>
@mergify mergify bot merged commit 4c1fe9d into main Oct 6, 2022
@mergify mergify bot deleted the vojta-redalarm branch October 6, 2022 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants