Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking Change in GitHub actions/upload-artifact@v4 #1103

Closed
misterjoshua opened this issue Sep 4, 2024 · 1 comment · Fixed by #1105
Closed

Breaking Change in GitHub actions/upload-artifact@v4 #1103

misterjoshua opened this issue Sep 4, 2024 · 1 comment · Fixed by #1105

Comments

@misterjoshua
Copy link

misterjoshua commented Sep 4, 2024

In GitHub's actions/upload-artifact#598, they disabled the inclusion of dot files/hidden files by default without releasing a major version change.

As a result, the cdk.out uploaded by CDK Pipelines for GitHub Workflows now omit dot files. The missing dot files have begun breaking several of my pipelines that rely on DockerImageFunctions that reference dotfiles like .yarnrc.yml while building a container image asset because required files are missing from the staged assets.

We need the upload-artifact action input to include include-hidden-files: true so the hidden files we require are included.

uses: 'actions/upload-artifact@v4',
with: {
name: output.fileSet.id,
path: output.directory,
},

References:

@kaizencc
Copy link
Contributor

kaizencc commented Sep 5, 2024

thanks for bringing this to my attention @misterjoshua! that seems like an unfortunate decision on their part but we can add the necessary update no problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants