test: make dataproviders static (#67)

cdn77 · Mar 13, 2023 · 52e2903 · 52e2903
1 parent c06d563
commit 52e2903
Show file tree

Hide file tree

Showing 6 changed files with 9 additions and 9 deletions.
diff --git a/README.md b/README.md
@@ -100,7 +100,7 @@ final class SuiteComplianceTest extends TestCaseBase
     }
 
     /** @return Generator<string, array{callable(self): TestCheck}> */
-    public function providerChecks() : Generator
+    public static function providerChecks() : Generator
     {
         $testDir = ROOT_PROJECT_DIR . '/tests';
         $testFilePathNames = \Symfony\Component\Finder\Finder::create()

diff --git a/tests/TestCheck/EveryTestHasGroupTest.php b/tests/TestCheck/EveryTestHasGroupTest.php
@@ -31,7 +31,7 @@ public function testFail(string $filePath): void
     }
 
     /** @return Generator<list<string>> */
-    public function providerFail(): Generator
+    public static function providerFail(): Generator
     {
         yield ['WithoutGroup.php'];
         yield ['WithUnlistedGroup.php'];

diff --git a/tests/TestCheck/EveryTestHasSameNamespaceAsCoveredClassTest.php b/tests/TestCheck/EveryTestHasSameNamespaceAsCoveredClassTest.php
@@ -22,7 +22,7 @@ public function testSuccess(string $filePath): void
     }
 
     /** @return Generator<array-key, list<string>> */
-    public function providerSuccess(): Generator
+    public static function providerSuccess(): Generator
     {
               $files = [
                   'IgnoreMultipleCoversTest.php',
@@ -52,7 +52,7 @@ public function testFail(string $filePath, string $error): void
     }
 
     /** @return Generator<array-key, list<string>> */
-    public function providerFail(): Generator
+    public static function providerFail(): Generator
     {
         yield [
             'CoversNonexistentClassTest.php',

diff --git a/tests/TestCheck/EveryTestHasSameNamespaceAsTestedClassTest.php b/tests/TestCheck/EveryTestHasSameNamespaceAsTestedClassTest.php
@@ -22,7 +22,7 @@ public function testSuccess(string $filePath): void
     }
 
     /** @return Generator<array-key, list<string>> */
-    public function providerSuccess(): Generator
+    public static function providerSuccess(): Generator
     {
         yield ['SameNamespaceTest.php'];
         yield ['SameNamespaceLinkedTest.php'];
@@ -43,7 +43,7 @@ public function testFail(string $filePath, string $error): void
     }
 
     /** @return Generator<array-key, list<string>> */
-    public function providerFail(): Generator
+    public static function providerFail(): Generator
     {
         yield [
             'MissingAnnotationsTest.php',

diff --git a/tests/TestCheck/EveryTestInheritsFromTestCaseBaseClassTest.php b/tests/TestCheck/EveryTestInheritsFromTestCaseBaseClassTest.php
@@ -22,7 +22,7 @@ public function testSuccess(string $filePath): void
     }
 
     /** @return Generator<list<string>> */
-    public function providerSuccess(): Generator
+    public static function providerSuccess(): Generator
     {
         yield ['ExtendsBase.php'];
         yield ['ExtendsBaseUsingParent.php'];
@@ -46,7 +46,7 @@ public function testFail(string $filePath): void
     }
 
     /** @return Generator<list<string>> */
-    public function providerFail(): Generator
+    public static function providerFail(): Generator
     {
         yield ['DoesNotExtendAnything.php'];
         yield ['DoesNotExtendBase.php'];

diff --git a/...ures/EveryTestHasSameNamespaceAsCoveredClass/tests/CoveredClassWithSomeWhitespaceTest.php b/...ures/EveryTestHasSameNamespaceAsCoveredClass/tests/CoveredClassWithSomeWhitespaceTest.php
@@ -4,7 +4,7 @@
 
 namespace Cdn77\TestUtils\Tests\Tests\TestCheck\Fixtures\EveryTestHasSameNamespaceAsCoveredClass;
 
-/** @covers       Cdn77\TestUtils\Tests\TestCheck\Fixtures\EveryTestHasSameNamespaceAsCoveredClass\SameNamespace */
+/** @covers \Cdn77\TestUtils\Tests\TestCheck\Fixtures\EveryTestHasSameNamespaceAsCoveredClass\SameNamespace */
 final class CoveredClassWithSomeWhitespaceTest
 {
 }