Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Add luxon #12220

Closed
tuananh opened this issue Nov 21, 2017 · 3 comments · Fixed by cdnjs/packages#17
Closed

[Request] Add luxon #12220

tuananh opened this issue Nov 21, 2017 · 3 comments · Fixed by cdnjs/packages#17
Labels
🏷 Library Request A request to add a new library to cdnjs 🚨 High Priority

Comments

@tuananh
Copy link

tuananh commented Nov 21, 2017

Library name: luxon
Library description: A powerful, modern, and friendly wrapper for Javascript dates and times.
Git repository url: https://github.com/moment/luxon
npm package name or url (if there is one): https://www.npmjs.com/package/luxon
License (List them all if it's multiple): MIT
Official homepage: http://moment.github.io/luxon/
Wanna say something? Leave message here:


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@sufuf3 sufuf3 added the 🏷 Library Request A request to add a new library to cdnjs label Nov 21, 2017
@sufuf3
Copy link
Contributor

sufuf3 commented Nov 21, 2017

@tuananh Thank you for your suggestion.
I found this lib provide http://moment.github.io/luxon/global/luxon.js and http://moment.github.io/luxon/global/luxon.min.js which CDNJS can host.
But there is no luxon.js and luxon.min.js in GitHub repo or npm.
It's a little bit hard for us to add this lib, because we use git auto-update or npm auto-update to get the files from upstream.
Could you discuss with the author to help add these files in GitHub repo or npm?
This will be a great work for us.
Thanks.

@tuananh
Copy link
Author

tuananh commented Nov 22, 2017

@icambron is it possible?

@icambron
Copy link
Contributor

icambron commented Nov 22, 2017

I really don't want to put the built files to the master branch in Github. As for NPM, the CJS "build" is not the same as the global one pointed to here.

An idea, though: use the gh-pages branch: https://github.com/moment/luxon/tree/gh-pages/global. That branch is what backs the website and I push to it when I release. Right now those aren't tagged with the release numbers, but if I figured out how to add that, would that suffice?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷 Library Request A request to add a new library to cdnjs 🚨 High Priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants