Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fermata@0.10.8 w/ npm auto-update #10684

Merged
merged 1 commit into from Feb 27, 2017
Merged

Add fermata@0.10.8 w/ npm auto-update #10684

merged 1 commit into from Feb 27, 2017

Conversation

kaocy
Copy link
Contributor

@kaocy kaocy commented Feb 21, 2017

Pull request for issue: #10656
Related issue(s): # #

Checklist for Pull request or lib adding request issue follows the conventions.

Note that if you are using a distribution purpose repository/package, please also provide the url and other related info like popularity of the source code repo/package.

Profile of the lib

Essential checklist

  • I'm the author of this library
    • I would like to add link to the page of this library on CDNJS on website / readme
  • This lib was not found on cdnjs repo
  • No already exist / duplicated issue and PR
  • The lib has notable popularity
    • More than 100 [Stars / Watchers / Forks] on [GitHub / Bitbucket]
    • More than 500 downloads stats per month on npm registry
  • Project has public repository on famous online hosting platform (or been hosted on npm)

Auto-update checklist

  • Has valid tags for each versions (for git auto-update)
  • Auto-update setup
  • Auto-update target/source is valid.
  • Auto-update filemap is correct.

Git commit checklist

  • The first line of commit message is less then 50 chars, be clean and clear, easy to understand.
  • The parent of the commit(s) in the PR is not old than 3 days.
  • Pull request is sending from a non-master branch with meaningful name.
  • Separate unrelated changes into different commits.
  • Use rebase to squash/fixup dummy/unnecessary commits into only one commit.
  • Close corresponding issue in commit message
  • Mention related issue(s), people in commit message, comment.

@kaocy
Copy link
Contributor Author

kaocy commented Feb 21, 2017

@x09326
Please review this PR. Thanks!

@x09326
Copy link
Contributor

x09326 commented Feb 22, 2017

@PeterDaveHello Is the beta version okay?

Copy link
Contributor

@PeterDaveHello PeterDaveHello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add the latest stable version, not the betas

@kaocy kaocy changed the title add fermata@0.11.0-beta1 w/ npm auto-update add fermata@0.10.8 w/ npm auto-update Feb 23, 2017
@kaocy kaocy changed the title add fermata@0.10.8 w/ npm auto-update Add fermata@0.10.8 w/ npm auto-update Feb 23, 2017
@kaocy
Copy link
Contributor Author

kaocy commented Feb 23, 2017

@x09326
I have modified it to the latest stable version.
Please review it again. Thanks!

@x09326
Copy link
Contributor

x09326 commented Feb 26, 2017

@lcd78706 Sorry for the late response, please rebase with the latest master branch, thanks.

@kaocy
Copy link
Contributor Author

kaocy commented Feb 27, 2017

@x09326
I have rebased with the latest master branch. Please review it again. Thanks!

@x09326
Copy link
Contributor

x09326 commented Feb 27, 2017

LGTM @cdnjs/intern2 please help me review it.

Copy link
Contributor

@pvnr0082t pvnr0082t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reason you didn't cc the author?

@kaocy
Copy link
Contributor Author

kaocy commented Feb 27, 2017

@pvnr0082t
Sorry, I forgot it, and I have modified it.
Please review it again. Thanks!

@x09326
Copy link
Contributor

x09326 commented Feb 27, 2017

LGTM

@PeterDaveHello
Copy link
Contributor

Thanks guys!

@PeterDaveHello
Copy link
Contributor

@x09326 please use "approve" feature instead of "LGTM", thanks.

@PeterDaveHello PeterDaveHello merged commit dc2cf27 into cdnjs:master Feb 27, 2017
PeterDaveHello added a commit that referenced this pull request Feb 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants