-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Shaka Player version numbers #11396
Conversation
This corrects the release numbers in Shaka Player v2.0.3, v2.0.4, and v2.1.3. Issue shaka-project/shaka-player#869
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joeyparrish congratulations! 0291219 CI test passed! ✅
Please wait for the further review from the maintainers!
For the details 📃, please take a look at ➡️ https://ci.cdnjs.com/cdnjs/cdnjs/9111, thank you 😀
@joeyparrish I'm afraid that this can't be done as we enabled SRI already and this change would make the current users' website broken, if it's only about version number, maybe we don't really need to touch it? |
I'm not familiar with SRI. What would break if we merged this PR? |
@joeyparrish Just think SRI is kind of checksum, the modified files would have different hashes so that the old would not work. Ref: https://www.w3.org/TR/SRI, https://developer.mozilla.org/en-US/docs/Web/Security/Subresource_Integrity |
I see. So based on that MDN article, if we change these files that have already gone out, they may appear to be malicious changes. Do I understand you correctly? |
@joeyparrish yes, that's why we shouldn't touch the published files. |
Okay, understood. I'll close this now. Thank you for your feedback. |
@joeyparrish Thanks. |
This corrects the release numbers in Shaka Player v2.0.3, v2.0.4, and
v2.1.3.
Closes shaka-project/shaka-player#869
Essential checklist
Git commit checklist