[New] Add vue-instant@1.0.2 w/ npm auto-update #12027

venkatramanareddy · 2017-10-21T09:09:53Z

Pull request for issue: #11975
Related issue(s): # #

Checklist for Pull request or lib adding request issue follows the conventions.

Note that if you are using a distribution purpose repository/package, please also provide the url and other related info like popularity of the source code repo/package.

Profile of the lib

Git repository (required): https://github.com/santiblanko/vue-instant
Official website (optional, not the repository): https://santiblanko.github.io/vue-instant/#/
NPM package url (optional): https://www.npmjs.com/package/vue-instant
License and its reference: MIT
GitHub / Bitbucket popularity (required):
- Count of watchers: 7
- Count of stars: 221
- Count of forks: 28
NPM download stats (optional):
- Downloads in the last day: 23
- Downloads in the last week: 157
- Downloads in the last month: 841

Essential checklist

I'm the author of this library
- I would like to add link to the page of this library on CDNJS on website / readme
This lib was not found on cdnjs repo
No already exist / duplicated issue and PR
The lib has notable popularity
- More than 200 [Stars / Watchers / Forks] on [GitHub / Bitbucket]
- More than 800 downloads stats per month on npm registry
Project has public repository on famous online hosting platform (or been hosted on npm)

Auto-update checklist

Has valid tags for each versions (for git auto-update)
Auto-update setup
Auto-update target/source is valid.
Auto-update filemap is correct.

Git commit checklist

The first line of commit message is less then 50 chars, be clean and clear, easy to understand.
The parent of the commit(s) in the PR is not old than 3 days.
Pull request is sending from a non-master branch with meaningful name.
Separate unrelated changes into different commits.
Use rebase to squash/fixup dummy/unnecessary commits into only one commit.
Close corresponding issue in commit message
Mention related issue(s), people in commit message, comment.

PeterBot

@venkatramanareddy congratulations! 0a2f9bb CI test passed! ✅
Please wait for the further review from the maintainers!

For the details 📃, please take a look at ➡️ https://ci.cdnjs.com/cdnjs/cdnjs/14112, thank you 😀

PeterBot

@venkatramanareddy congratulations! ba47539 CI test passed! ✅
Please wait for the further review from the maintainers!

For the details 📃, please take a look at ➡️ https://ci.cdnjs.com/cdnjs/cdnjs/14501, thank you 😀

sufuf3

LGTM
@venkatramanareddy Nice work.
Helped update commit message because the author is santiblanko not verglor and minify the .css file.

@cdnjs/library-reviewer Please help review this PR, thanks.

extend1994

Wondering vue-instant.common.js is for a browser? It seems for commonjs.
@venkatramanareddy @sufuf3 Do you know about this?

sufuf3 · 2017-11-05T06:21:42Z

@extend1994 I think we can discuss this.
I know that vue-instant.common.js should be used in CommonJS environment not be used in browser. (https://github.com/santiblanko/vue-instant/blob/master/config/webpack.config.common.js#L15)

But as I know there are another ways can let CommonJS/Node.js require module loader for the browser, such as https://github.com/Stuk/require1k or https://github.com/ruanyf/tiny-browser-require.

Then, we still can use it in front-end (https://webpack.github.io/docs/usage.html).

But I am still a new hand to learning Javascript bundler.

@PeterDaveHello Could you give us some suggestion in this issue?
Many Thanks.

PeterDaveHello · 2017-11-17T17:52:12Z

Ask its author or find the answer from the doc please, I can't know every case.

maruilian11

And please remove 1.0.2/vue-instant.common.js. Thanks!

maruilian11 · 2017-12-03T09:40:16Z

ajax/libs/vue-instant/package.json

+    {
+      "basePath": "dist",
+      "files": [
+        "**/*"


Please use "!(vue-instant.common.js)" rather than "**/*" in this case because vue-instant.common.js can't be used in browser.

maruilian11 · 2017-12-03T09:44:54Z

And please modify your commit msg to:

Add vue-instant@1.0.2 w/ npm auto-update

And minify vue-instant.css with web-minify-helper
close #11975, cc @santiblanko

The msg body should be wrapped in 72 characters.

extend1994 · 2018-01-22T15:27:41Z

@venkatramanareddy Would you like to continue this PR?

PeterBot

@venkatramanareddy congratulations! 9942d57 CI test passed! ✅
Please wait for the further review from the maintainers!

For the details 📃, please take a look at ➡️ https://ci.cdnjs.com/cdnjs/cdnjs/17437, thank you 😀

venkatramanareddy · 2018-01-28T06:13:53Z

@extend1994 I've done the necessary changes. Apologies for the delay

extend1994

Sorry for late review!

extend1994 · 2018-02-04T05:27:48Z

ajax/libs/vue-instant/package.json

+    {
+      "basePath": "dist",
+      "files": [
+        "!(vue-instant.common.js)"


Let's use **/!(vue-instant.common.js) instead, it can fetches files under sub-directories compared to the original one.

PeterBot

@venkatramanareddy congratulations! 4e09d97 CI test passed! ✅
Please wait for the further review from the maintainers!

For the details 📃, please take a look at ➡️ https://ci.cdnjs.com/cdnjs/cdnjs/17658, thank you 😀

Can't use "Rebase and merge". Going to rebase from my side to approve and merge this PR

@santiblanko

And minify vue-instant.css with web-minify-helper close cdnjs#11975, cc @santiblanko

PeterBot

@venkatramanareddy congratulations! 347351e CI test passed! ✅
Please wait for the further review from the maintainers!

For the details 📃, please take a look at ➡️ https://ci.cdnjs.com/cdnjs/cdnjs/17840, thank you 😀

PeterBot requested review from dakshshah96, extend1994, maruilian11, sashberd and sufuf3 October 21, 2017 09:09

PeterBot approved these changes Oct 21, 2017

View reviewed changes

sufuf3 force-pushed the vue-instant branch from 0a2f9bb to ba47539 Compare October 31, 2017 06:04

ghost assigned sufuf3 Oct 31, 2017

ghost added the in progress label Oct 31, 2017

PeterBot approved these changes Oct 31, 2017

View reviewed changes

sufuf3 approved these changes Oct 31, 2017

View reviewed changes

sufuf3 changed the title ~~Add vue-instant@1.0.2 w/ npm auto-update~~ [New] Add vue-instant@1.0.2 w/ npm auto-update Oct 31, 2017

extend1994 reviewed Oct 31, 2017

View reviewed changes

maruilian11 suggested changes Dec 3, 2017

View reviewed changes

PeterDaveHello requested review from extend1994, sufuf3 and maruilian11 December 13, 2017 16:07

venkatramanareddy force-pushed the vue-instant branch from ba47539 to 9942d57 Compare January 28, 2018 06:09

PeterBot approved these changes Jan 28, 2018

View reviewed changes

extend1994 suggested changes Feb 4, 2018

View reviewed changes

venkatramanareddy force-pushed the vue-instant branch from 9942d57 to 4e09d97 Compare February 4, 2018 08:21

PeterBot approved these changes Feb 4, 2018

View reviewed changes

extend1994 previously approved these changes Feb 9, 2018

View reviewed changes

Add vue-instant@1.0.2 w/ npm auto-update

347351e

And minify vue-instant.css with web-minify-helper close cdnjs#11975, cc @santiblanko

extend1994 force-pushed the vue-instant branch from 4e09d97 to 347351e Compare February 9, 2018 13:50

ghost assigned extend1994 Feb 9, 2018

PeterBot approved these changes Feb 9, 2018

View reviewed changes

extend1994 approved these changes Feb 9, 2018

View reviewed changes

extend1994 merged commit fa5e317 into cdnjs:master Feb 9, 2018

ghost removed the in progress label Feb 9, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[New] Add vue-instant@1.0.2 w/ npm auto-update #12027

[New] Add vue-instant@1.0.2 w/ npm auto-update #12027

venkatramanareddy commented Oct 21, 2017 •

edited by extend1994

PeterBot left a comment

PeterBot left a comment

sufuf3 left a comment

extend1994 left a comment

sufuf3 commented Nov 5, 2017

PeterDaveHello commented Nov 17, 2017

maruilian11 left a comment

maruilian11 Dec 3, 2017

maruilian11 commented Dec 3, 2017

extend1994 commented Jan 22, 2018

PeterBot left a comment

venkatramanareddy commented Jan 28, 2018

extend1994 left a comment

extend1994 Feb 4, 2018

PeterBot left a comment

PeterBot left a comment

[New] Add vue-instant@1.0.2 w/ npm auto-update #12027

[New] Add vue-instant@1.0.2 w/ npm auto-update #12027

Conversation

venkatramanareddy commented Oct 21, 2017 • edited by extend1994

Profile of the lib

Essential checklist

Auto-update checklist

Git commit checklist

PeterBot left a comment

Choose a reason for hiding this comment

PeterBot left a comment

Choose a reason for hiding this comment

sufuf3 left a comment

Choose a reason for hiding this comment

extend1994 left a comment

Choose a reason for hiding this comment

sufuf3 commented Nov 5, 2017

PeterDaveHello commented Nov 17, 2017

maruilian11 left a comment

Choose a reason for hiding this comment

maruilian11 Dec 3, 2017

Choose a reason for hiding this comment

maruilian11 commented Dec 3, 2017

extend1994 commented Jan 22, 2018

PeterBot left a comment

Choose a reason for hiding this comment

venkatramanareddy commented Jan 28, 2018

extend1994 left a comment

Choose a reason for hiding this comment

extend1994 Feb 4, 2018

Choose a reason for hiding this comment

PeterBot left a comment

Choose a reason for hiding this comment

PeterBot left a comment

Choose a reason for hiding this comment

venkatramanareddy commented Oct 21, 2017 •

edited by extend1994