Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[author] [new] Add jquery-ajax-unobtrusive via npm auto-update #13029

Merged
merged 7 commits into from
Mar 23, 2020

Conversation

javiercn
Copy link
Contributor

Adds jquery-ajax-unobtrusive under libs/ajax/jquery-validation-unobtrusive using a package.json with npm auto-update config.

Pull request template for new library

Pull request for issue: #12790
Related issue(s): #11976

Checklist for Pull request or lib adding request issue follows the conventions.

Note that if you are using a distribution purpose repository/package, please also provide the url and other related info like popularity of the source code repo/package.

Profile of the lib

Essential checklist

  • I'm the author of this library
    • I would like to add link to the page of this library on CDNJS on website / readme
  • This lib was not found on cdnjs repo
  • Doesn't already exist / has duplicate issue and PR
  • The lib has notable popularity
    • More than 200 [Stars / Watchers / Forks] on [GitHub / Bitbucket]
    • More than 800 downloads stats per month on npm registry
  • Project has public repository on famous online hosting platform (or been hosted on npm)

Auto-update checklist

  • Has valid tags for each versions (for git auto-update)
  • Auto-update setup
  • Auto-update target/source is valid.
  • Auto-update filemap is correct.

Git commit checklist

  • The first line of commit message is less then 50 chars; clean, clear and easy to understand.
  • The parent of the commit(s) in the PR is not older than 3 days.
  • Pull request is sent from a non-master branch with a meaningful name.
  • Separate unrelated changes into different commits.
  • Use rebase to squash/fixup dummy/unnecessary commits into only one commit.
  • Close corresponding issue in commit message
  • Mention related issue(s), people in commit message, comment.

[Fixes cdnjs#12790, cdnjs#11976] Adds jquery-ajax-unobtrusive under libs/ajax/jquery-ajax-unobtrusive using a package.json with npm auto-update config.

/cc: @elipton @mkArtakMSFT
Copy link
Contributor

@PeterBot PeterBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@javiercn congratulations! 80fb384 CI test passed! ✅
Please wait for the further review from the maintainers!

For the details 📃, please take a look at ➡️ https://ci.cdnjs.com/cdnjs/cdnjs/23677, thank you 😀

Copy link
Contributor

@PeterDaveHello PeterDaveHello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This path /libs/ajax/jquery-ajax-unobtrusive/package.json was wrong, it should be /ajax/libs/jquery-ajax-unobtrusive/package.json

Copy link
Contributor

@sashberd sashberd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You package json file is not answer our package.json format. Please review out contribution section and update your file according to cdnjs rules

@Ragowit
Copy link

Ragowit commented Jun 25, 2019

@javiercn Any update on those change requests? Would love to have this package included into cdnjs.

@PeterDaveHello
Copy link
Contributor

Seems to be pending for requested changes, feel free to send a new one for those waiting for changes but without any updates.

libs/ajax/jquery-ajax-unobtrusive/package.json Outdated Show resolved Hide resolved
libs/ajax/jquery-ajax-unobtrusive/package.json Outdated Show resolved Hide resolved
libs/ajax/jquery-ajax-unobtrusive/package.json Outdated Show resolved Hide resolved
libs/ajax/jquery-ajax-unobtrusive/package.json Outdated Show resolved Hide resolved
libs/ajax/jquery-ajax-unobtrusive/package.json Outdated Show resolved Hide resolved
xtuc and others added 5 commits March 22, 2020 18:49
Co-Authored-By: Matt (IPv4) Cowley <me@mattcowley.co.uk>
Co-Authored-By: Matt (IPv4) Cowley <me@mattcowley.co.uk>
Co-Authored-By: Matt (IPv4) Cowley <me@mattcowley.co.uk>
Co-Authored-By: Matt (IPv4) Cowley <me@mattcowley.co.uk>
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@MattIPv4 MattIPv4 merged commit c3351bc into cdnjs:master Mar 23, 2020
robocdnjs added a commit to cdnjs/packages that referenced this pull request Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants