-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[author] [new] Add jquery-ajax-unobtrusive via npm auto-update #13029
[author] [new] Add jquery-ajax-unobtrusive via npm auto-update #13029
Conversation
[Fixes cdnjs#12790, cdnjs#11976] Adds jquery-ajax-unobtrusive under libs/ajax/jquery-ajax-unobtrusive using a package.json with npm auto-update config. /cc: @elipton @mkArtakMSFT
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@javiercn congratulations! 80fb384 CI test passed! ✅
Please wait for the further review from the maintainers!
For the details 📃, please take a look at ➡️ https://ci.cdnjs.com/cdnjs/cdnjs/23677, thank you 😀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This path /libs/ajax/jquery-ajax-unobtrusive/package.json
was wrong, it should be /ajax/libs/jquery-ajax-unobtrusive/package.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You package json file is not answer our package.json format. Please review out contribution section and update your file according to cdnjs rules
@javiercn Any update on those change requests? Would love to have this package included into cdnjs. |
Seems to be pending for requested changes, feel free to send a new one for those waiting for changes but without any updates. |
Co-Authored-By: Matt (IPv4) Cowley <me@mattcowley.co.uk>
Co-Authored-By: Matt (IPv4) Cowley <me@mattcowley.co.uk>
Co-Authored-By: Matt (IPv4) Cowley <me@mattcowley.co.uk>
Co-Authored-By: Matt (IPv4) Cowley <me@mattcowley.co.uk>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
Adds jquery-ajax-unobtrusive under libs/ajax/jquery-validation-unobtrusive using a package.json with npm auto-update config.
Pull request template for new library
Pull request for issue: #12790
Related issue(s): #11976
Checklist for Pull request or lib adding request issue follows the conventions.
Note that if you are using a distribution purpose repository/package, please also provide the url and other related info like popularity of the source code repo/package.
Profile of the lib
Essential checklist
Auto-update checklist
Git commit checklist