[author] Update SimpleBar v3.1.x with new auto-update config #13150

Grsmto · 2018-12-15T02:10:24Z

Update SimpleBar after folder structure change.

Thanks!

Pull request for issue: #13102

Git commit checklist

The first line of commit message is less then 50 chars; clean, clear and easy to understand.
The parent of the commit(s) in the PR is not older than 3 days.
Pull request is sent from a non-master branch with a meaningful name.
Separate unrelated changes into different commits.
Use rebase to squash/fixup dummy/unnecessary commits into only one commit.
Close corresponding issue in commit message
Mention related issue(s), people in commit message, comment.

PeterBot

Oops 😨 f5f7aa6 CI test failed ❗

@Grsmto please take a look at CI build https://ci.cdnjs.com/cdnjs/cdnjs/24781 for details 📝 !
Most of the error will have corresponding explanation, so that you will know what's wrong and then try to fix it!
If you cannot understand the error message and need help, feel free to ask our maintainers ☺️

PeterBot

Oops 😨 e05df5d CI test failed ❗

@Grsmto please take a look at CI build https://ci.cdnjs.com/cdnjs/cdnjs/24783 for details 📝 !
Most of the error will have corresponding explanation, so that you will know what's wrong and then try to fix it!
If you cannot understand the error message and need help, feel free to ask our maintainers ☺️

PeterBot

@Grsmto congratulations! 7a801d1 CI test passed! ✅
Please wait for the further review from the maintainers!

For the details 📃, please take a look at ➡️ https://ci.cdnjs.com/cdnjs/cdnjs/24806, thank you 😀

sashberd

LGTM

ajax/libs/simplebar/package.json

PeterBot

Oops 😨 f988665 CI test failed ❗

@Grsmto please take a look at CI build https://ci.cdnjs.com/cdnjs/cdnjs/25115 for details 📝 !
Most of the error will have corresponding explanation, so that you will know what's wrong and then try to fix it!
If you cannot understand the error message and need help, feel free to ask our maintainers ☺️

PeterBot

Oops 😨 835d96f CI test failed ❗

@Grsmto please take a look at CI build https://ci.cdnjs.com/cdnjs/cdnjs/25118 for details 📝 !
Most of the error will have corresponding explanation, so that you will know what's wrong and then try to fix it!
If you cannot understand the error message and need help, feel free to ask our maintainers ☺️

PeterBot

@Grsmto congratulations! b263e8d CI test passed! ✅
Please wait for the further review from the maintainers!

For the details 📃, please take a look at ➡️ https://ci.cdnjs.com/cdnjs/cdnjs/25133, thank you 😀

extend1994 · 2019-01-07T02:59:53Z

Hi @Grsmto Could you also commit latest version and specify it in package.json with another commit ? When I attempted to do that for you, it shows that ! [remote rejected] simplebar -> refs/pull/13150/head (permission denied).
After that version is added, the other versions would be added by cdnjs bot @PeterBot

PeterBot

Oops 😨 764bb1f CI test failed ❗

@Grsmto please take a look at CI build https://ci.cdnjs.com/cdnjs/cdnjs/25161 for details 📝 !
Most of the error will have corresponding explanation, so that you will know what's wrong and then try to fix it!
If you cannot understand the error message and need help, feel free to ask our maintainers ☺️

PeterBot

Oops 😨 2307c10 CI test failed ❗

@Grsmto please take a look at CI build https://ci.cdnjs.com/cdnjs/cdnjs/25162 for details 📝 !
Most of the error will have corresponding explanation, so that you will know what's wrong and then try to fix it!
If you cannot understand the error message and need help, feel free to ask our maintainers ☺️

PeterBot

@Grsmto congratulations! b4d5e91 CI test passed! ✅
Please wait for the further review from the maintainers!

For the details 📃, please take a look at ➡️ https://ci.cdnjs.com/cdnjs/cdnjs/25163, thank you 😀

extend1994

Usually, we add the file from npm/GitHub to make sure file integrity, not sure if the differences below are fine?

ajax/libs/simplebar/3.1.1/simplebar.js

PeterBot

Oops 😨 3a14228 CI test failed ❗

@Grsmto please take a look at CI build https://ci.cdnjs.com/cdnjs/cdnjs/25292 for details 📝 !
Most of the error will have corresponding explanation, so that you will know what's wrong and then try to fix it!
If you cannot understand the error message and need help, feel free to ask our maintainers ☺️

PeterBot

@Grsmto congratulations! 26072da CI test passed! ✅
Please wait for the further review from the maintainers!

For the details 📃, please take a look at ➡️ https://ci.cdnjs.com/cdnjs/cdnjs/25293, thank you 😀

PeterBot

@Grsmto congratulations! 45f6074 CI test passed! ✅
Please wait for the further review from the maintainers!

For the details 📃, please take a look at ➡️ https://ci.cdnjs.com/cdnjs/cdnjs/25298, thank you 😀

Grsmto · 2019-01-21T12:38:31Z

@extend1994 sorry for the ping but we might be good to merge?

extend1994 · 2019-01-23T08:39:02Z

@Grsmto Sorry for the delay, I think *.esm.* should be removed in this PR?
Other files are good to go now 👍

olafcm · 2019-02-01T15:35:32Z

@Grsmto Thanks for all the work! And sorry to ask you again, but I think only a minor change in package.json is required to get it working again, right? Would be very much appreciated to get it working again 😃

PeterBot

Oops 😨 e0838e4 CI test failed ❗

@Grsmto please take a look at CI build https://ci.cdnjs.com/cdnjs/cdnjs/25642 for details 📝 !
Most of the error will have corresponding explanation, so that you will know what's wrong and then try to fix it!
If you cannot understand the error message and need help, feel free to ask our maintainers ☺️

PeterBot

@Grsmto congratulations! 1925476 CI test passed! ✅
Please wait for the further review from the maintainers!

For the details 📃, please take a look at ➡️ https://ci.cdnjs.com/cdnjs/cdnjs/25644, thank you 😀

olafcm · 2019-02-05T11:11:48Z

@extend1994 Can you please help to have the pull request merged so the lib is being updated on cdnjs again? Thanks! 👍 👍

PeterDaveHello · 2019-02-05T11:12:11Z

@olafcm let me take a look 👍

PeterDaveHello · 2019-02-05T11:39:30Z

ajax/libs/simplebar/3.1.1/simplebar.js

@@ -172,7 +172,7 @@
    return store[key] || (store[key] = value !== undefined ? value : {});
  })('versions', []).push({
    version: _core.version,
-    mode: 'global',
+    mode: _library ? 'pure' : 'global',


This file was added from the previous commit, which also claims it's the latest, it's weird to be updated again here, is there anything I missed here?

@Grsmto would you please take a look? Thanks.

I have no idea why this was updated.
To be honest I spent so so so much time on this PR, I think I'm about to give up. Every time I need to update something I spend at least an hour with the process in here :(

I double checked and the file are 1:1 with the npm version. It was a mistake from a while back. As I'm hard pushing it looks like it's from the latest commit but it's not.

However of course in between I released a new version of SimpleBar (3.1.3) so I need to add that version as well before this can be merged.......

@PeterDaveHello ok one more try here! I added the latest version of SimpleBar 3.1.3.
Hope this is good to merge 🙏

I know it's a little bit hard working on a huge repository, and thanks for your time on it! To provide the best integrity and reliable service, we just need to make sure the files are correct, that's why I take a deeper look into the pull request. I'll take another check here soon to see if everything is okay.

BTW, not sure if you enabled sparse checkout, which will let you not spend so much time on it.

So it should be at b25f999ec3787872e45ba531fe1467d8b60160c4 or bbb10c7a3af24a7b1d505851ae14e323efc2826a, one of them contains the wrong files, I'll check that.

Looks like the later commit is correct, the previous isn't.

As the wrong history here is no needed in the repositoy, do you mind to do a little final revise to fix that? It'll be even better to mention the exact version in the commit message, instead of the "latest" version, as when you need to reace the update history here(Fix v3.1.1 in the previous commit, or, simple suqash that two commit of adding new versions) and see many of the latest, the more precise the more clear.

Thanks again.

Squashed everything under 1 commit which was the original commit message.

Actually, the preferred form here is to separate the config part and the assets in the individual commit, the reason why I mention the squash is that the previous one of the assets adding commit was containing wrong content, which was fixed in the later commit, then a suqash can help you make it disappear in that situation, anyway, I'll try to make this one easier, get it merged ASAP, thanks again!

PeterBot

Oops 😨 0328edb CI test failed ❗

@Grsmto please take a look at CI build https://ci.cdnjs.com/cdnjs/cdnjs/25707 for details 📝 !
Most of the error will have corresponding explanation, so that you will know what's wrong and then try to fix it!
If you cannot understand the error message and need help, feel free to ask our maintainers ☺️

PeterBot

@Grsmto congratulations! 9c499a8 CI test passed! ✅
Please wait for the further review from the maintainers!

For the details 📃, please take a look at ➡️ https://ci.cdnjs.com/cdnjs/cdnjs/25724, thank you 😀

olafcm · 2019-02-07T10:35:39Z

@PeterDaveHello Thank you kindly for your support. Is it ready for final merge now? I see v3.1.0 is hosted already (
https://cdnjs.com/libraries/simplebar/3.1.0).

PeterDaveHello · 2019-02-07T10:51:08Z

Sure! Merged!

olafcm · 2019-02-07T11:49:26Z

Working perfect, thank you so much @PeterDaveHello and @Grsmto!!

PeterBot requested review from dakshshah96, extend1994, sashberd and sufuf3 December 15, 2018 02:10

PeterBot suggested changes Dec 15, 2018

View reviewed changes

Grsmto force-pushed the simplebar branch from f5f7aa6 to e05df5d Compare December 15, 2018 03:04

PeterBot suggested changes Dec 15, 2018

View reviewed changes

Grsmto force-pushed the simplebar branch from e05df5d to 7a801d1 Compare December 15, 2018 23:36

PeterBot approved these changes Dec 15, 2018

View reviewed changes

sashberd approved these changes Dec 16, 2018

View reviewed changes

extend1994 reviewed Dec 21, 2018

View reviewed changes

ajax/libs/simplebar/package.json Outdated Show resolved Hide resolved

Grsmto force-pushed the simplebar branch from 7a801d1 to f988665 Compare January 5, 2019 21:28

PeterBot suggested changes Jan 5, 2019

View reviewed changes

Grsmto force-pushed the simplebar branch from f988665 to 835d96f Compare January 5, 2019 22:32

PeterBot suggested changes Jan 5, 2019

View reviewed changes

Grsmto force-pushed the simplebar branch from 835d96f to b263e8d Compare January 7, 2019 02:00

PeterBot approved these changes Jan 7, 2019

View reviewed changes

PeterBot suggested changes Jan 8, 2019

View reviewed changes

Grsmto force-pushed the simplebar branch from 764bb1f to 2307c10 Compare January 8, 2019 01:28

PeterBot suggested changes Jan 8, 2019

View reviewed changes

Grsmto force-pushed the simplebar branch from 2307c10 to b4d5e91 Compare January 8, 2019 01:37

PeterBot approved these changes Jan 8, 2019

View reviewed changes

extend1994 reviewed Jan 10, 2019

View reviewed changes

ajax/libs/simplebar/3.1.1/simplebar.js Outdated Show resolved Hide resolved

ajax/libs/simplebar/3.1.1/simplebar.js Outdated Show resolved Hide resolved

PeterBot suggested changes Jan 14, 2019

View reviewed changes

Grsmto force-pushed the simplebar branch from 3a14228 to 26072da Compare January 14, 2019 02:29

PeterBot approved these changes Jan 14, 2019

View reviewed changes

Grsmto force-pushed the simplebar branch from 26072da to 45f6074 Compare January 14, 2019 10:41

PeterBot approved these changes Jan 14, 2019

View reviewed changes

Grsmto force-pushed the simplebar branch from 45f6074 to e0838e4 Compare February 3, 2019 21:08

PeterBot suggested changes Feb 3, 2019

View reviewed changes

Grsmto force-pushed the simplebar branch from e0838e4 to 1925476 Compare February 4, 2019 00:54

PeterBot approved these changes Feb 4, 2019

View reviewed changes

PeterDaveHello reviewed Feb 5, 2019

View reviewed changes

Grsmto force-pushed the simplebar branch from 1925476 to bbb10c7 Compare February 5, 2019 12:15

Grsmto force-pushed the simplebar branch from bbb10c7 to 0328edb Compare February 5, 2019 15:25

PeterBot suggested changes Feb 6, 2019

View reviewed changes

Update Simplebar after folder structure change (fix cdnjs#13102)

9c499a8

PeterDaveHello force-pushed the simplebar branch from 0328edb to 9c499a8 Compare February 6, 2019 13:47

ghost assigned PeterDaveHello Feb 6, 2019

ghost added the in progress label Feb 6, 2019

PeterBot approved these changes Feb 6, 2019

View reviewed changes

PeterDaveHello changed the title ~~[author] Update SimpleBar after folder structure change~~ [author] Update SimpleBar v3.1.x with new auto-update config Feb 7, 2019

PeterDaveHello merged commit 2d71042 into cdnjs:master Feb 7, 2019

ghost removed the in progress label Feb 7, 2019

Grsmto mentioned this pull request Feb 7, 2019

Simplebar v3 not on cdnjs Grsmto/simplebar#241

Closed

[author] Update SimpleBar v3.1.x with new auto-update config #13150

[author] Update SimpleBar v3.1.x with new auto-update config #13150

Conversation

Grsmto commented Dec 15, 2018 • edited

Git commit checklist

PeterBot left a comment

Choose a reason for hiding this comment

PeterBot left a comment

Choose a reason for hiding this comment

PeterBot left a comment

Choose a reason for hiding this comment

sashberd left a comment

Choose a reason for hiding this comment

PeterBot left a comment

Choose a reason for hiding this comment

PeterBot left a comment

Choose a reason for hiding this comment

PeterBot left a comment

Choose a reason for hiding this comment

extend1994 commented Jan 7, 2019 • edited

PeterBot left a comment

Choose a reason for hiding this comment

PeterBot left a comment

Choose a reason for hiding this comment

PeterBot left a comment

Choose a reason for hiding this comment

extend1994 left a comment

Choose a reason for hiding this comment

PeterBot left a comment

Choose a reason for hiding this comment

PeterBot left a comment

Choose a reason for hiding this comment

PeterBot left a comment

Choose a reason for hiding this comment

Grsmto commented Jan 21, 2019

extend1994 commented Jan 23, 2019

olafcm commented Feb 1, 2019

PeterBot left a comment

Choose a reason for hiding this comment

PeterBot left a comment

Choose a reason for hiding this comment

olafcm commented Feb 5, 2019

PeterDaveHello commented Feb 5, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

PeterDaveHello Feb 6, 2019 • edited

Choose a reason for hiding this comment

PeterBot left a comment

Choose a reason for hiding this comment

PeterBot left a comment

Choose a reason for hiding this comment

olafcm commented Feb 7, 2019

PeterDaveHello commented Feb 7, 2019

olafcm commented Feb 7, 2019

Grsmto commented Dec 15, 2018 •

edited

extend1994 commented Jan 7, 2019 •

edited

PeterDaveHello Feb 6, 2019 •

edited