[Author] [New] Add FlexSearch.js with git auto-update via single package.json #13245

ts-thomas · 2019-02-06T21:43:21Z

Pull request template for new library

Pull request for issue: #
Related issue(s): # #

Checklist for Pull request or lib adding request issue follows the conventions.

Note that if you are using a distribution purpose repository/package, please also provide the url and other related info like popularity of the source code repo/package.

Profile of the lib

Git repository (required): https://github.com/nextapps-de/flexsearch
Official website (optional, not the repository):
NPM package url (optional): https://www.npmjs.com/package/flexsearch
License and its reference: Apache-2.0 https://github.com/nextapps-de/flexsearch/blob/master/LICENSE
GitHub / Bitbucket popularity (required):
- Count of watchers: 30
- Count of stars: 2664
- Count of forks: 45
NPM download stats (optional):
- Downloads in the last day:
- Downloads in the last week:
- Downloads in the last month: 1767

Essential checklist

I'm the author of this library
- I would like to add link to the page of this library on CDNJS on website / readme
This lib was not found on cdnjs repo
Doesn't already exist / has duplicate issue and PR
The lib has notable popularity
- More than 200 [Stars / Watchers / Forks] on [GitHub / Bitbucket]
- More than 800 downloads stats per month on npm registry
Project has public repository on famous online hosting platform (or been hosted on npm)

Auto-update checklist

Has valid tags for each versions (for git auto-update)
Auto-update setup
Auto-update target/source is valid.
Auto-update filemap is correct.

Git commit checklist

The first line of commit message is less then 50 chars; clean, clear and easy to understand.
The parent of the commit(s) in the PR is not older than 3 days.
Pull request is sent from a non-master branch with a meaningful name.
Separate unrelated changes into different commits.
Use rebase to squash/fixup dummy/unnecessary commits into only one commit.
Close corresponding issue in commit message
Mention related issue(s), people in commit message, comment.

PeterBot

Oops 😨 f2d4f36 CI test failed ❗

@ts-thomas please take a look at CI build https://ci.cdnjs.com/cdnjs/cdnjs/25742 for details 📝 !
Most of the error will have corresponding explanation, so that you will know what's wrong and then try to fix it!
If you cannot understand the error message and need help, feel free to ask our maintainers ☺️

PeterDaveHello · 2019-02-06T21:45:21Z

@ts-thomas Maybe you'd also like to try to reuse a pull request instead of opening new one 😏?

PeterDaveHello · 2019-02-06T21:46:54Z

@ts-thomas you can just commit on the branch you sending this pull request, it'll be updated ;)

ts-thomas · 2019-02-06T21:48:00Z

Ok sorry, there was a message that the forked master branch was too old^^

PeterDaveHello · 2019-02-06T21:48:44Z

@ts-thomas Oh, I didn't notice that, can also help you update it if you're not working locally ;)

ts-thomas · 2019-02-06T21:50:19Z

Hopefully now its fine :)

PeterBot

@ts-thomas congratulations! af2c0d1 CI test passed! ✅
Please wait for the further review from the maintainers!

For the details 📃, please take a look at ➡️ https://ci.cdnjs.com/cdnjs/cdnjs/25743, thank you 😀

ajax/libs/FlexSearch/package.json

PeterDaveHello · 2019-02-06T21:58:54Z

@ts-thomas cool, I'll help squash the commits into a single one, and take a look later ;)

PeterBot

@ts-thomas congratulations! 059adfa CI test passed! ✅
Please wait for the further review from the maintainers!

For the details 📃, please take a look at ➡️ https://ci.cdnjs.com/cdnjs/cdnjs/25744, thank you 😀

ts-thomas · 2019-02-06T22:01:04Z

Squashing would be great, I'm currently just on Github, thanks a lot :)

PeterBot

@ts-thomas congratulations! 82dba94 CI test passed! ✅
Please wait for the further review from the maintainers!

For the details 📃, please take a look at ➡️ https://ci.cdnjs.com/cdnjs/cdnjs/25745, thank you 😀

MattIPv4 · 2019-02-26T10:57:55Z

@ts-thomas Is there a default file for this library?

ts-thomas · 2019-02-26T13:50:44Z

Hello, yes it is. The file „flexsearch.min.js“ is the default file.

MattIPv4 · 2019-02-26T14:54:55Z

@ts-thomas Could you set that as the filename property in the json?

ajax/libs/FlexSearch/package.json

PeterBot

Oops 😨 ba2b5d0 CI test failed ❗

@ts-thomas please take a look at CI build https://ci.cdnjs.com/cdnjs/cdnjs/26030 for details 📝 !
Most of the error will have corresponding explanation, so that you will know what's wrong and then try to fix it!
If you cannot understand the error message and need help, feel free to ask our maintainers ☺️

PeterBot

Oops 😨 7ea4131 CI test failed ❗

@ts-thomas please take a look at CI build https://ci.cdnjs.com/cdnjs/cdnjs/26031 for details 📝 !
Most of the error will have corresponding explanation, so that you will know what's wrong and then try to fix it!
If you cannot understand the error message and need help, feel free to ask our maintainers ☺️

ts-thomas · 2019-02-28T16:17:16Z

@MattIPv4 Done. Thanks.

ajax/libs/FlexSearch/package.json

PeterBot

@ts-thomas congratulations! 86efe31 CI test passed! ✅
Please wait for the further review from the maintainers!

For the details 📃, please take a look at ➡️ https://ci.cdnjs.com/cdnjs/cdnjs/26041, thank you 😀

ts-thomas

Fix filename in package.json

PeterBot

@ts-thomas congratulations! a6e12e1 CI test passed! ✅
Please wait for the further review from the maintainers!

For the details 📃, please take a look at ➡️ https://ci.cdnjs.com/cdnjs/cdnjs/26058, thank you 😀

PeterDaveHello · 2019-03-02T09:20:01Z

Here we go 🎉
https://cdnjs.com/libraries/FlexSearch

ts-thomas · 2019-03-02T09:47:42Z

Nice one 👍

PeterBot requested review from dakshshah96, extend1994, sashberd and sufuf3 February 6, 2019 21:43

PeterBot suggested changes Feb 6, 2019

View reviewed changes

PeterBot approved these changes Feb 6, 2019

View reviewed changes

PeterDaveHello reviewed Feb 6, 2019

View reviewed changes

ajax/libs/FlexSearch/package.json Outdated Show resolved Hide resolved

PeterDaveHello changed the title ~~Add FlexSearch.js~~ [Author] [New] Add FlexSearch.js with git auto-update via single package.json Feb 6, 2019

PeterBot approved these changes Feb 6, 2019

View reviewed changes

ghost assigned PeterDaveHello Feb 6, 2019

ghost added the in progress label Feb 6, 2019

PeterBot approved these changes Feb 6, 2019

View reviewed changes

PeterDaveHello reviewed Feb 28, 2019

View reviewed changes

ajax/libs/FlexSearch/package.json Outdated Show resolved Hide resolved

PeterBot suggested changes Feb 28, 2019

View reviewed changes

PeterDaveHello reviewed Feb 28, 2019

View reviewed changes

ajax/libs/FlexSearch/package.json Outdated Show resolved Hide resolved

PeterBot approved these changes Feb 28, 2019

View reviewed changes

ts-thomas commented Feb 28, 2019

View reviewed changes

PeterDaveHello approved these changes Mar 2, 2019

View reviewed changes

Add FlexSearch.js

a6e12e1

PeterBot approved these changes Mar 2, 2019

View reviewed changes

PeterDaveHello merged commit b390037 into cdnjs:master Mar 2, 2019

ghost removed the in progress label Mar 2, 2019

PeterDaveHello added a commit that referenced this pull request Mar 2, 2019

Import FlexSearch from git repository, cc #13245

920b5ef

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Author] [New] Add FlexSearch.js with git auto-update via single package.json #13245

[Author] [New] Add FlexSearch.js with git auto-update via single package.json #13245

ts-thomas commented Feb 6, 2019 •

edited

PeterBot left a comment

PeterDaveHello commented Feb 6, 2019

PeterDaveHello commented Feb 6, 2019

ts-thomas commented Feb 6, 2019 •

edited

PeterDaveHello commented Feb 6, 2019

ts-thomas commented Feb 6, 2019

PeterBot left a comment

PeterDaveHello commented Feb 6, 2019

PeterBot left a comment

ts-thomas commented Feb 6, 2019

PeterBot left a comment

MattIPv4 commented Feb 26, 2019

ts-thomas commented Feb 26, 2019

MattIPv4 commented Feb 26, 2019

PeterBot left a comment

PeterBot left a comment

ts-thomas commented Feb 28, 2019

PeterBot left a comment

ts-thomas left a comment

PeterBot left a comment

PeterDaveHello commented Mar 2, 2019

ts-thomas commented Mar 2, 2019

[Author] [New] Add FlexSearch.js with git auto-update via single package.json #13245

[Author] [New] Add FlexSearch.js with git auto-update via single package.json #13245

Conversation

ts-thomas commented Feb 6, 2019 • edited

Pull request template for new library

Profile of the lib

Essential checklist

Auto-update checklist

Git commit checklist

PeterBot left a comment

Choose a reason for hiding this comment

PeterDaveHello commented Feb 6, 2019

PeterDaveHello commented Feb 6, 2019

ts-thomas commented Feb 6, 2019 • edited

PeterDaveHello commented Feb 6, 2019

ts-thomas commented Feb 6, 2019

PeterBot left a comment

Choose a reason for hiding this comment

PeterDaveHello commented Feb 6, 2019

PeterBot left a comment

Choose a reason for hiding this comment

ts-thomas commented Feb 6, 2019

PeterBot left a comment

Choose a reason for hiding this comment

MattIPv4 commented Feb 26, 2019

ts-thomas commented Feb 26, 2019

MattIPv4 commented Feb 26, 2019

PeterBot left a comment

Choose a reason for hiding this comment

PeterBot left a comment

Choose a reason for hiding this comment

ts-thomas commented Feb 28, 2019

PeterBot left a comment

Choose a reason for hiding this comment

ts-thomas left a comment

Choose a reason for hiding this comment

PeterBot left a comment

Choose a reason for hiding this comment

PeterDaveHello commented Mar 2, 2019

ts-thomas commented Mar 2, 2019

ts-thomas commented Feb 6, 2019 •

edited

ts-thomas commented Feb 6, 2019 •

edited