New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Author] [New] Add FlexSearch.js with git auto-update via single package.json #13245

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@ts-thomas
Copy link

ts-thomas commented Feb 6, 2019

Pull request template for new library

Pull request for issue: #
Related issue(s): # #

Checklist for Pull request or lib adding request issue follows the conventions.

Note that if you are using a distribution purpose repository/package, please also provide the url and other related info like popularity of the source code repo/package.

Profile of the lib

Essential checklist

  • I'm the author of this library
    • I would like to add link to the page of this library on CDNJS on website / readme
  • This lib was not found on cdnjs repo
  • Doesn't already exist / has duplicate issue and PR
  • The lib has notable popularity
    • More than 200 [Stars / Watchers / Forks] on [GitHub / Bitbucket]
    • More than 800 downloads stats per month on npm registry
  • Project has public repository on famous online hosting platform (or been hosted on npm)

Auto-update checklist

  • Has valid tags for each versions (for git auto-update)
  • Auto-update setup
  • Auto-update target/source is valid.
  • Auto-update filemap is correct.

Git commit checklist

  • The first line of commit message is less then 50 chars; clean, clear and easy to understand.
  • The parent of the commit(s) in the PR is not older than 3 days.
  • Pull request is sent from a non-master branch with a meaningful name.
  • Separate unrelated changes into different commits.
  • Use rebase to squash/fixup dummy/unnecessary commits into only one commit.
  • Close corresponding issue in commit message
  • Mention related issue(s), people in commit message, comment.

@PeterBot PeterBot requested review from dakshshah96 , extend1994 , sashberd and sufuf3 Feb 6, 2019

@PeterBot
Copy link
Member

PeterBot left a comment

Oops 😨 f2d4f36 CI test failed ❗️

@ts-thomas please take a look at CI build https://ci.cdnjs.com/cdnjs/cdnjs/25742 for details 📝 !
Most of the error will have corresponding explanation, so that you will know what's wrong and then try to fix it!
If you cannot understand the error message and need help, feel free to ask our maintainers ☺️

@PeterDaveHello

This comment has been minimized.

Copy link
Member

PeterDaveHello commented Feb 6, 2019

@ts-thomas Maybe you'd also like to try to reuse a pull request instead of opening new one 😏?

@PeterDaveHello

This comment has been minimized.

Copy link
Member

PeterDaveHello commented Feb 6, 2019

@ts-thomas you can just commit on the branch you sending this pull request, it'll be updated ;)

@ts-thomas

This comment has been minimized.

Copy link
Author

ts-thomas commented Feb 6, 2019

Ok sorry, there was a message that the forked master branch was too old^^

@PeterDaveHello

This comment has been minimized.

Copy link
Member

PeterDaveHello commented Feb 6, 2019

@ts-thomas Oh, I didn't notice that, can also help you update it if you're not working locally ;)

@ts-thomas

This comment has been minimized.

Copy link
Author

ts-thomas commented Feb 6, 2019

Hopefully now its fine :)

@PeterBot
Copy link
Member

PeterBot left a comment

@ts-thomas congratulations! af2c0d1 CI test passed!
Please wait for the further review from the maintainers!

For the details 📃, please take a look at ➡️ https://ci.cdnjs.com/cdnjs/cdnjs/25743, thank you 😀

"flexsearch.min.js",
"flexsearch.compact.js",
"flexsearch.light.js",
"flexsearch.es5.js"

This comment has been minimized.

@PeterDaveHello

PeterDaveHello Feb 6, 2019

Member

Just to make sure, these are all working with browsers, right? Maybe try "!(flexsearch.node.js)" here to just ignore the one we don't need here?

This comment has been minimized.

@ts-thomas

ts-thomas Feb 6, 2019

Author

Thanks for the hint. All files are browser compatible. The flexsearch.node.js is also compatible but its just a special version for node.js (without web-worker parts).

@PeterDaveHello PeterDaveHello changed the title Add FlexSearch.js [Author] [New] Add FlexSearch.js with git auto-update via single package.json Feb 6, 2019

@PeterDaveHello

This comment has been minimized.

Copy link
Member

PeterDaveHello commented Feb 6, 2019

@ts-thomas cool, I'll help squash the commits into a single one, and take a look later ;)

@PeterBot
Copy link
Member

PeterBot left a comment

@ts-thomas congratulations! 059adfa CI test passed!
Please wait for the further review from the maintainers!

For the details 📃, please take a look at ➡️ https://ci.cdnjs.com/cdnjs/cdnjs/25744, thank you 😀

@ts-thomas

This comment has been minimized.

Copy link
Author

ts-thomas commented Feb 6, 2019

Squashing would be great, I'm currently just on Github, thanks a lot :)

@PeterDaveHello PeterDaveHello force-pushed the ts-thomas:add_flexsearch branch from 059adfa to 82dba94 Feb 6, 2019

@wafflebot wafflebot bot added the in progress label Feb 6, 2019

@PeterBot
Copy link
Member

PeterBot left a comment

@ts-thomas congratulations! 82dba94 CI test passed!
Please wait for the further review from the maintainers!

For the details 📃, please take a look at ➡️ https://ci.cdnjs.com/cdnjs/cdnjs/25745, thank you 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment