add incremental-dom v0.2.0 #5823

maruilian11 · 2015-10-04T10:22:31Z

git repo url: https://github.com/google/incremental-dom
Watch 72
Star 1,483
Fork 46
@LeaYeh could u help me check this PR for #5729 ? thank you!

Not found on cdnjs repo
No already exist issue and PR
Notable popularity
Project has public repository on famous online hosting platform (or been hosted on npm)
Has valid tags for each versions (for git auto-update)
Auto-update setup
Auto-update target/source is valid.
Auto-update filemap is correct

PeterDaveHello · 2015-10-04T10:27:28Z

ajax/libs/incremental-dom/package.json

+    {
+      "basePath": "dist",
+      "files": [
+        "incremental-dom*.+(js|map)"


why not **/*?

LeaYeh · 2015-10-13T15:57:35Z

@maruilian11 why you add npm autoupdate config but not git config?

maruilian11 · 2015-10-13T16:17:02Z

@LeaYeh i'm not sure if i use git auto-update, i can get dist folder.
cc #5729

PeterDaveHello · 2015-10-14T04:23:47Z

npm is good

LeaYeh · 2015-10-16T07:03:36Z

@maruilian11 ok, i think this pr is ok, plz rebase it again :)
@PeterDaveHello plz check this pr

PeterDaveHello · 2015-10-16T07:49:41Z

@LeaYeh You should ping me after the rebase, not now ...

PeterDaveHello · 2015-10-16T07:49:58Z

@LeaYeh And the pr's title is too long.

LeaYeh · 2015-10-16T09:07:17Z

@PeterDaveHello sorry for that, and what is the max len of title?

PeterDaveHello · 2015-10-16T09:22:35Z

I think, maybe within 50 chars, like add incremental-dom v0.2.0

maruilian11 · 2015-10-20T05:25:08Z

@LeaYeh is that ok？

LeaYeh · 2015-10-22T08:21:28Z

i think it is fine
@PeterDaveHello

PeterDaveHello · 2015-10-22T08:22:11Z

should rebase ... @LeaYeh don't you know that or forgot again?

maruilian11 · 2015-11-06T16:14:08Z

@LeaYeh i have rebased it ~

LeaYeh · 2015-11-07T08:21:05Z

ok, this pr is ok.
@PeterDaveHello could you check this pr for me?

PeterDaveHello · 2015-11-07T08:45:12Z

Don't you need to add the manually minified file incremental-dom-cjs.min.js into requiredFiles array?
And also I wonder if we really need it, maybe it's not for browser, if it's for browser, the official developer may minify it as like incremental-dom-min.js, please confirm that @LeaYeh .

maruilian11 · 2015-12-02T09:43:25Z

@LeaYeh could you help me check the PR again?
i use !(incremental-dom-cjs*) to not include incremental-dom-cjs* in dist

maruilian11 · 2015-12-20T17:43:48Z

@Amomo could you help me check this PR? thank you~

maruilian11 · 2016-01-17T03:58:26Z

ping @LeaYeh

PeterDaveHello · 2016-01-17T09:35:09Z

i use !(incremental-dom-cjs_) to not include incremental-dom-cjs_ in dist

Did you confirm that is incremental-dom-cjs for browser or not?

I wonder if this project if for browser usage or not ...

maruilian11 · 2016-01-17T11:45:37Z

@PeterDaveHello yes, cc google/incremental-dom#186

@sparhami

close cdnjs#5729, cc @sparhami

add incremental-dom v0.2.0

PeterDaveHello added the in progress label Oct 4, 2015

maruilian11 force-pushed the incremental-dom branch from 0dca08f to 4e4c4c8 Compare October 4, 2015 10:26

PeterDaveHello reviewed Oct 4, 2015
View reviewed changes

ajax/libs/incremental-dom/package.json

{

"basePath": "dist",

"files": [

"incremental-dom*.+(js|map)"

Copy link

Contributor

PeterDaveHello Oct 4, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not **/*?

maruilian11 assigned LeaYeh Oct 4, 2015

maruilian11 force-pushed the incremental-dom branch from 4e4c4c8 to b8e9f56 Compare October 4, 2015 10:53

maruilian11 changed the title ~~add incremental-dom v0.2.0 with npm auto-update, close #5729~~ add incremental-dom v0.2.0 Oct 16, 2015

maruilian11 force-pushed the incremental-dom branch 2 times, most recently from 8289766 to ff7b731 Compare October 20, 2015 05:24

maruilian11 assigned maruilian11 and unassigned LeaYeh Oct 23, 2015

maruilian11 force-pushed the incremental-dom branch from ff7b731 to 210fac4 Compare October 26, 2015 09:50

maruilian11 force-pushed the incremental-dom branch from 210fac4 to 2b5521e Compare November 6, 2015 16:00

maruilian11 mentioned this pull request Nov 30, 2015

is incremental-dom-cjs.js for browser? google/incremental-dom#186

Closed

maruilian11 force-pushed the incremental-dom branch from 2b5521e to 767b184 Compare December 2, 2015 09:41

maruilian11 removed their assignment Dec 2, 2015

maruilian11 assigned LeaYeh Dec 2, 2015

maruilian11 assigned Piicksarn and unassigned LeaYeh Dec 11, 2015

maruilian11 force-pushed the incremental-dom branch from 767b184 to 03947d8 Compare December 11, 2015 08:14

maruilian11 assigned Amomo and unassigned Piicksarn Dec 20, 2015

maruilian11 force-pushed the incremental-dom branch from 03947d8 to d522678 Compare December 20, 2015 17:44

PeterDaveHello assigned LeaYeh and unassigned Amomo Dec 21, 2015

maruilian11 force-pushed the incremental-dom branch from d522678 to cf19362 Compare January 8, 2016 16:10

maruilian11 force-pushed the incremental-dom branch from cf19362 to c124c3e Compare January 17, 2016 03:46

add incremental-dom v0.2.0 with npm auto-update

c124c3e

close cdnjs#5729, cc @sparhami

PeterDaveHello added a commit that referenced this pull request Jan 17, 2016

Merge pull request #5823 from maruilian11/incremental-dom

7aa6939

add incremental-dom v0.2.0

PeterDaveHello merged commit 7aa6939 into cdnjs:master Jan 17, 2016

PeterDaveHello removed the in progress label Jan 17, 2016

maruilian11 deleted the incremental-dom branch January 17, 2016 14:30

sufuf3 mentioned this pull request Aug 16, 2017

[New] Add route-recognizer@0.3.3 w/ npm auto-update #11497

Closed

19 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add incremental-dom v0.2.0 #5823

add incremental-dom v0.2.0 #5823

maruilian11 commented Oct 4, 2015

PeterDaveHello Oct 4, 2015

LeaYeh commented Oct 13, 2015

maruilian11 commented Oct 13, 2015

PeterDaveHello commented Oct 14, 2015

LeaYeh commented Oct 16, 2015

PeterDaveHello commented Oct 16, 2015

PeterDaveHello commented Oct 16, 2015

LeaYeh commented Oct 16, 2015

PeterDaveHello commented Oct 16, 2015

maruilian11 commented Oct 20, 2015

LeaYeh commented Oct 22, 2015

PeterDaveHello commented Oct 22, 2015

maruilian11 commented Nov 6, 2015

LeaYeh commented Nov 7, 2015

PeterDaveHello commented Nov 7, 2015

maruilian11 commented Dec 2, 2015

maruilian11 commented Dec 20, 2015

maruilian11 commented Jan 17, 2016

PeterDaveHello commented Jan 17, 2016

maruilian11 commented Jan 17, 2016

add incremental-dom v0.2.0 #5823

add incremental-dom v0.2.0 #5823

Conversation

maruilian11 commented Oct 4, 2015

PeterDaveHello Oct 4, 2015

Choose a reason for hiding this comment

LeaYeh commented Oct 13, 2015

maruilian11 commented Oct 13, 2015

PeterDaveHello commented Oct 14, 2015

LeaYeh commented Oct 16, 2015

PeterDaveHello commented Oct 16, 2015

PeterDaveHello commented Oct 16, 2015

LeaYeh commented Oct 16, 2015

PeterDaveHello commented Oct 16, 2015

maruilian11 commented Oct 20, 2015

LeaYeh commented Oct 22, 2015

PeterDaveHello commented Oct 22, 2015

maruilian11 commented Nov 6, 2015

LeaYeh commented Nov 7, 2015

PeterDaveHello commented Nov 7, 2015

maruilian11 commented Dec 2, 2015

maruilian11 commented Dec 20, 2015

maruilian11 commented Jan 17, 2016

PeterDaveHello commented Jan 17, 2016

maruilian11 commented Jan 17, 2016