New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[new] add leaflet-plugins@1.3.12 with git auto-update #6149
Conversation
It's fine! the main files shown in bower.json :
|
hmmmm ... I would like to ask author to confirm that. @shramov would you please give us some advice if we wanna host this lib on the cdn? Thanks. |
Hi @brunob would you please give us some advice if we wanna host this lib on the cdn? |
@Amomo there is no main file, each script is independent, the scripts listed in bower file seems ok for me. |
@brunob thanks for your response! :-D |
cf3edf4
to
956885c
Compare
@Piicksarn I have rebased this PR, could you check it again? Thank you! |
@PeterDaveHello, I think the pr is fine! |
Duplicated file map ... |
@PeterDaveHello sorry, I am not sure what does your "Duplicated file map" means. Or, could you please point out which part I did it wrong? Thank you! |
"control/Permalink*.js", | ||
"control/Permalink.Layer*.js", | ||
"control/Permalink.Line*.js", | ||
"control/Permalink.Marker*.js", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't "control/Permalink*.js"
include "control/Permalink.Layer*.js"
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yes! Thanks a lot.
956885c
to
8f44a92
Compare
@Piicksarn Would you mind to check this PR for me? Thank you~ :-) |
@LeaYeh @maruilian11 would you please also help review this PR? Thanks. |
@PeterDaveHello, the pr is fine. |
@PeterDaveHello i think the pr is ok. |
2 days ago ... |
@Amomo could you rebase the commits? |
8f44a92
to
66da4c6
Compare
@maruilian11 @PeterDaveHello @Piicksarn thank you. |
@Amomo sorry... could you rebase it again 😞 |
66da4c6
to
bd0e7cb
Compare
@maruilian11 I have updated it to v1.4.2, could you help me check this PR again? |
@Amomo sorry..again😭 |
bd0e7cb
to
997f4fe
Compare
@maruilian11 Could you help me check it again? Thank you~ :-D |
@PeterDaveHello i think this PR is ok. |
@Piicksarn @LeaYeh please help double check this, thanks. |
Hi @Piicksarn
For #6137, I add leaflet-plugins at v1.3.12 and add git auto-update config in its package.json.
repo: https://github.com/shramov/leaflet-plugins
As README.md and bower.json said, I add
Vector layers (layer/vector/)
,Providers (layer/tile)
,(layer/)
andcontrol plugins (control/)
.This library contains plugins of leaflet, so it don't has a main file.
Randomly, I pick "layer/vector/OSM.min.js" for filename field.
Would you mind checking this PR for me? Thank you~ :-D
54
, Star440
, Fork206