[New] Manually add timbre w/ npm auto-update #6295

maruilian11 · 2015-11-24T16:05:51Z

git repo url: https://github.com/mohayonao/timbre.js
Watch 59
Star 611
Fork 50
@Piicksarn could u help me check this PR for #6110 ? thank you!

Not found on cdnjs repo
No already exist issue and PR
Notable popularity
Project has public repository on famous online hosting platform (or been hosted on npm)
Has valid tags for each versions (for git auto-update)
Auto-update setup
Auto-update target/source is valid.
Auto-update filemap is correct

Piicksarn · 2015-11-25T16:38:02Z

@PeterDaveHello, I think the pr is fine!
would you mind to have a look at the pr?
Thank you!

maruilian11 · 2015-11-25T16:44:22Z

@Piicksarn i have rebased it, could you help me check it again?

maruilian11 · 2015-11-30T11:19:59Z

@Amomo could you help me check this PR? thank you!

Amomo · 2015-11-30T12:02:45Z

@maruilian11
According to its README.md, I think "timbre.node.js" is a node module.
We should add "timbre.dev.js", not "timbre.node.js".

Amomo · 2015-11-30T12:03:52Z

ajax/libs/timbre/package.json

+      "timbre.node*.js"
+    ]
+  },
+  "requiredFiles": [


You have point the minified file in "filename" field, no need to add "requiredFiles".

maruilian11 · 2015-12-20T17:42:21Z

@Amomo thank you~ i have modified it~

Amomo · 2015-12-21T14:31:01Z

@PeterDaveHello I think this PR is fine, could you take a look? Thank you! :-)

PeterDaveHello · 2015-12-21T15:43:59Z

Use dev file as main file is strange, any other source we can use to import or download the files?

PeterDaveHello · 2017-03-19T12:44:04Z

Any updates here? Thanks!

maruilian11 · 2017-03-19T13:44:07Z

@PeterDaveHello ping the author in the issue.
mohayonao/timbre.js#57 (comment)

PeterBot · 2017-04-04T00:05:18Z

Any updates here? Thanks!

PeterBot · 2017-04-25T20:04:02Z

Any updates here? Thanks!

maruilian11 · 2017-07-14T09:17:54Z

@PeterDaveHello I use Gruntfile.js to generate timbre.js and timbre.js.map, and find timbre.js source is timbre.dev.js. Since the author has no replied for a long time, can we directly add timbre.js and timbre.dev.js in this case?

PeterDaveHello · 2017-07-16T16:41:24Z

We can manually build and add it from tagged commit in this situation.

PeterDaveHello · 2017-09-17T13:29:44Z

That's funny ... isn't this simply working? uglifyjs --source-map -o timbre.js timbre.dev.js

I think it clearly told you the problem, didn't it? ERROR: './timbre.js.map' is not a supported option

So you both stock on the problem that you don't take a clear look at the error message ...

Take a look at the help message and I didn't see any of them telling to specify the filename of map file (so where is option --unsafe come from? The earlier version?):


peter $ uglifyjs -V
uglify-js 3.1.1

peter $ uglifyjs --help

  Usage: uglifyjs [options] [files...]


  Options:

    -V, --version                output the version number
    -p, --parse <options>        Specify parser options.
    -c, --compress [options]     Enable compressor/specify compressor options.
    -m, --mangle [options]       Mangle names/specify mangler options.
    --mangle-props [options]     Mangle properties/specify mangler options.
    -b, --beautify [options]     Beautify output/specify output options.
    -o, --output <file>          Output file (default STDOUT).
    --comments [filter]          Preserve copyright comments in the output.
    --config-file <file>         Read minify() options from JSON file.
    -d, --define <expr>[=value]  Global definitions.
    --ie8                        Support non-standard Internet Explorer 8.
    --keep-fnames                Do not mangle/drop function names. Useful for code relying on Function.prototype.name.
    --name-cache <file>          File to hold mangled name mappings.
    --self                       Build UglifyJS as a library (implies --wrap UglifyJS)
    --source-map [options]       Enable source map/specify source map options.
    --timings                    Display operations run time on STDERR.
    --toplevel                   Compress and/or mangle variables in toplevel scope.
    --verbose                    Print diagnostic messages.
    --warn                       Print warning messages.
    --wrap <name>                Embed everything as a function with “exports” corresponding to “name” globally.
    -h, --help                   output usage information

The options should be used IMO should be --compress, --source-map & --mangle, remove the source map option when you don't need it.

WIP

PeterDaveHello

Anyway, I didn't see a need to use Makefile to make the non-minified dist file in version 13.02.06 as it's already there, isn't it? @maruilian11 ?

So what all you may need to do is to minify some versions?

Please clearly mention the details in the commit message and comment so that reviewer can understand what's really going on here.

maruilian11 · 2017-09-20T16:24:23Z

@PeterDaveHello I think @sufuf3 looked the error msg and find the problem. So you may misunstand her.

maruilian11 · 2017-09-20T16:28:02Z

Anyway, I didn't see a need to use Makefile to make the non-minified dist file in version 13.02.06 as it's already there, isn't it? @maruilian11 ?

@PeterDaveHello Sorry, I don't get your meaning. I didn't use Makefile to make the non-minified dist file, but to produce a official file of it.

PeterDaveHello · 2017-09-20T16:28:33Z

@maruilian11 The file is already there, isn't it?

maruilian11 · 2017-09-25T16:35:54Z

@PeterDaveHello Yes, timbre.dev.js is already there, but timbre.js and timbre.js.map need to be produced.

PeterDaveHello · 2017-09-28T16:30:24Z

So you don't need to deal with Makefile, do you?

To summarize the situation here, this PR is waiting for some versions need to be added manually and those versions need manually minification also? If so, can we simply use git ignore them to make the case simple?

maruilian11 · 2017-09-30T04:56:17Z

@PeterDaveHello I don't get it. You mean we minify ourself? Not through the Makefile?

PeterDaveHello · 2017-09-30T04:56:56Z

@maruilian11 Does Makefile contain the minification part? I don't think so ...

maruilian11 · 2017-09-30T05:03:43Z

@PeterDaveHello Yes, it does.
Following content is from timbre@13.1.18 Makefile in npm package:

gh-pages: clear
@UglifyJS --unsafe -nc -nm -o ./timbre.js ./timbre.dev.js

PeterDaveHello · 2017-10-03T01:11:38Z

Okay, fine, it's part of gh-pages which is not a common case.

PeterDaveHello · 2017-10-03T01:13:25Z

So let's finish this PR ASAP? Just add the few missing versions.

@mohayonao

`timbre.js` and `timbre.js.map` are built from Gruntfile.js. close cdnjs#6110, cc @mohayonao

Manually add them from npm package because `timbre.js` and `timbre.js.map` need to be built manually.

Manually add them from git repo because `timbre.js` needs to be built manually. v13.01.20: mohayonao/timbre.js@0becae5 v13.02.02: mohayonao/timbre.js@b24652e v13.02.06: mohayonao/timbre.js@afb9507 v13.04.19: mohayonao/timbre.js@698bd23 Others are added accord to git tag. cc cdnjs#6110

maruilian11 · 2017-10-03T13:37:26Z

@PeterDaveHello The test seems not working. Please take a look.

PeterBot · 2018-04-19T20:01:37Z

Any updates here? Please let me know if you need any help. Thanks!

(This is an automatic ping message, sorry for disturbing, we will get back here ASAP.)

cc @sashberd

sashberd · 2018-04-22T15:34:46Z

I have tried to rebase and push tis commit in order to send it again to check. The rebase was succeed, but push provides me next message:
"To https://github.com/maruilian11/cdnjs.git
! [remote rejected] timbre -> timbre (permission denied)
error: failed to push some refs to 'https://github.com/maruilian11/cdnjs.git'
"

@extend1994 @sufuf3 @PeterDaveHello

sashberd · 2018-04-30T13:31:27Z

@PeterDaveHello Is this PR only need to be rebased and then merged?

xtuc

Remove the versions and only commit ajax/libs/timbre/package.json

sashberd · 2020-02-25T20:41:25Z

Moved to #13700

maruilian11 assigned Piicksarn Nov 24, 2015

PeterDaveHello added the in progress label Nov 24, 2015

Piicksarn assigned PeterDaveHello and unassigned Piicksarn Nov 25, 2015

maruilian11 force-pushed the timbre branch from e2d3ab7 to 6432ebc Compare November 25, 2015 16:42

maruilian11 force-pushed the timbre branch from 6432ebc to 80dc2a0 Compare November 30, 2015 10:49

maruilian11 assigned Amomo and unassigned PeterDaveHello Nov 30, 2015

Amomo reviewed Nov 30, 2015
View reviewed changes

maruilian11 force-pushed the timbre branch 2 times, most recently from bfcd874 to 4707294 Compare December 20, 2015 17:41

Amomo assigned PeterDaveHello and unassigned Amomo Dec 21, 2015

maruilian11 mentioned this pull request Jan 17, 2016

files hosted on cdnjs mohayonao/timbre.js#57

Open

PeterDaveHello assigned maruilian11 and unassigned PeterDaveHello May 28, 2016

maruilian11 added the 🔄 Wait for response label Dec 5, 2016

PeterDaveHello suggested changes Sep 17, 2017

View reviewed changes

maruilian11 added 3 commits October 3, 2017 21:07

[New] Add timbre@14.11.25 w/ npm auto-update

f5d4367

`timbre.js` and `timbre.js.map` are built from Gruntfile.js. close cdnjs#6110, cc @mohayonao

Manually add timbre v13.1.18 ~ v14.10.12, cc cdnjs#6110

abe0a1a

Manually add them from npm package because `timbre.js` and `timbre.js.map` need to be built manually.

maruilian11 force-pushed the timbre branch from 426ed5c to f487bcc Compare October 3, 2017 13:08

sufuf3 requested review from PeterDaveHello, sufuf3 and extend1994 and removed request for pvnr0082t December 27, 2017 08:51

xtuc requested changes Feb 20, 2020

View reviewed changes

robocdnjs force-pushed the master branch from 3e20989 to eae91de Compare February 20, 2020 19:54

sashberd closed this Feb 25, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[New] Manually add timbre w/ npm auto-update #6295

[New] Manually add timbre w/ npm auto-update #6295

maruilian11 commented Nov 24, 2015

Piicksarn commented Nov 25, 2015

maruilian11 commented Nov 25, 2015

maruilian11 commented Nov 30, 2015

Amomo commented Nov 30, 2015

Amomo Nov 30, 2015

maruilian11 commented Dec 20, 2015

Amomo commented Dec 21, 2015

PeterDaveHello commented Dec 21, 2015

PeterDaveHello commented Mar 19, 2017

maruilian11 commented Mar 19, 2017

PeterBot commented Apr 4, 2017

PeterBot commented Apr 25, 2017

maruilian11 commented Jul 14, 2017

PeterDaveHello commented Jul 16, 2017

PeterDaveHello commented Sep 17, 2017 •

edited

Loading

PeterDaveHello left a comment

maruilian11 commented Sep 20, 2017

maruilian11 commented Sep 20, 2017

PeterDaveHello commented Sep 20, 2017

maruilian11 commented Sep 25, 2017

PeterDaveHello commented Sep 28, 2017

maruilian11 commented Sep 30, 2017

PeterDaveHello commented Sep 30, 2017

maruilian11 commented Sep 30, 2017

PeterDaveHello commented Oct 3, 2017

PeterDaveHello commented Oct 3, 2017

maruilian11 commented Oct 3, 2017

PeterBot commented Apr 19, 2018

sashberd commented Apr 22, 2018

sashberd commented Apr 30, 2018

xtuc left a comment

sashberd commented Feb 25, 2020

[New] Manually add timbre w/ npm auto-update #6295

[New] Manually add timbre w/ npm auto-update #6295

Conversation

maruilian11 commented Nov 24, 2015

Piicksarn commented Nov 25, 2015

maruilian11 commented Nov 25, 2015

maruilian11 commented Nov 30, 2015

Amomo commented Nov 30, 2015

Amomo Nov 30, 2015

Choose a reason for hiding this comment

maruilian11 commented Dec 20, 2015

Amomo commented Dec 21, 2015

PeterDaveHello commented Dec 21, 2015

PeterDaveHello commented Mar 19, 2017

maruilian11 commented Mar 19, 2017

PeterBot commented Apr 4, 2017

PeterBot commented Apr 25, 2017

maruilian11 commented Jul 14, 2017

PeterDaveHello commented Jul 16, 2017

PeterDaveHello commented Sep 17, 2017 • edited Loading

PeterDaveHello left a comment

Choose a reason for hiding this comment

maruilian11 commented Sep 20, 2017

maruilian11 commented Sep 20, 2017

PeterDaveHello commented Sep 20, 2017

maruilian11 commented Sep 25, 2017

PeterDaveHello commented Sep 28, 2017

maruilian11 commented Sep 30, 2017

PeterDaveHello commented Sep 30, 2017

maruilian11 commented Sep 30, 2017

PeterDaveHello commented Oct 3, 2017

PeterDaveHello commented Oct 3, 2017

maruilian11 commented Oct 3, 2017

PeterBot commented Apr 19, 2018

sashberd commented Apr 22, 2018

sashberd commented Apr 30, 2018

xtuc left a comment

Choose a reason for hiding this comment

sashberd commented Feb 25, 2020

PeterDaveHello commented Sep 17, 2017 •

edited

Loading