Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add git auto-update config of prism, close #6612 #6617

Merged
merged 2 commits into from Mar 1, 2016
Merged

Conversation

maruilian11
Copy link
Contributor

@Piicksarn could you help me check the PR for #6612 ? thank you!

@PeterDaveHello
Copy link
Contributor

What about the themes?
PS: npm package: https://www.npmjs.com/package/prismjs

@maruilian11
Copy link
Contributor Author

@PeterDaveHello but npm package only have versions under 1.0.0, according to the issue, 1.3.0 is required, or we use npm auto-update, then add versions to 1.3.0 by an other PR?

@PeterDaveHello
Copy link
Contributor

@PeterDaveHello but npm package only have versions under 1.0.0, according to the issue, 1.3.0 is required, or we use npm auto-update, the add version to 1.3.0 by an other PR?

Okay, if so, don't use it.

@maruilian11 maruilian11 force-pushed the prism-2 branch 2 times, most recently from 17eeca8 to 60afd75 Compare January 2, 2016 17:48
@maruilian11
Copy link
Contributor Author

@PeterDaveHello i had some mistakes, npm package do have v1.3.0, so i still use npm auto-update config.

@PeterDaveHello
Copy link
Contributor

@maruilian11 Okay, i was wondering why i saw v1.3.0 earlier...

@PeterDaveHello
Copy link
Contributor

Failed.

@maruilian11
Copy link
Contributor Author

@PeterDaveHello the error message said...

/ajax/libs/prism/0.0.1/plugins/autolinker/prism-autolinker.min.css does not exist but is required!

i thought adding auto-update config doesn't need to add new file?
so, in this case, i need to add a new version ?

@maruilian11 maruilian11 force-pushed the prism-2 branch 3 times, most recently from 2b2237f to 8aa0daf Compare January 3, 2016 08:53
@maruilian11
Copy link
Contributor Author

@PeterDaveHello i have added v1.3.0.

@PeterDaveHello
Copy link
Contributor

If you have problem with npm, use git auto-update.

@maruilian11 maruilian11 force-pushed the prism-2 branch 3 times, most recently from 5600574 to 4b16c71 Compare January 6, 2016 19:03
@maruilian11
Copy link
Contributor Author

@PeterDaveHello i have changed to git auto-update.

@maruilian11
Copy link
Contributor Author

@Piicksarn could you help me check this PR?

@maruilian11
Copy link
Contributor Author

ping @Piicksarn

@Piicksarn
Copy link
Contributor

@maruilian11, sorry for my delay, would you please rebase to master again?
😢

@maruilian11
Copy link
Contributor Author

@Piicksarn @Amomo could you help me check this PR? it's a little in hurry.

@maruilian11
Copy link
Contributor Author

@Amomo thank you, i have corrected it~

@Amomo
Copy link
Contributor

Amomo commented Feb 29, 2016

@PeterDaveHello
maruilian11 added files from "components/", "plugins/", "themes/" and "prism.js" with their minified file at v1.4.1 in the first commit. No file is lost.
Then, she add npm auto-update config in package.json.

I think this PR is fine. Could you take a look, thanks!

@Amomo Amomo assigned PeterDaveHello and unassigned Amomo Feb 29, 2016
@PeterDaveHello
Copy link
Contributor

@Amomo Okay

@maruilian11
Copy link
Contributor Author

@PeterDaveHello please check the auto-update config, thanks.

PeterDaveHello added a commit that referenced this pull request Mar 1, 2016
add git auto-update config of prism, close #6612
@PeterDaveHello PeterDaveHello merged commit baeb25d into master Mar 1, 2016
@PeterDaveHello PeterDaveHello deleted the prism-2 branch March 1, 2016 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants