Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing "filename" requirement for autoupdate #6765

Closed
wants to merge 3 commits into from
Closed

Add missing "filename" requirement for autoupdate #6765

wants to merge 3 commits into from

Conversation

Mottie
Copy link
Contributor

@Mottie Mottie commented Jan 20, 2016

While performing an npm test, I discovered that a "filename" property is required for an autoupdate setup:

    my-repo
      ✗ my-repo package.json is valid
        » my-repo is not a valid cdnjs package.json format:
          » NPM package.json
                Property is required (true): /properties/filename // valid-packages-test.js:82

      ✗ my-repo: filename from package.json exists
        » ./ajax/libs/my-repo/1.0.0/undefined does not exist but is referenced in package.json! // valid-packages-test.js:101

@PeterDaveHello
Copy link
Contributor

@Mottie all the package.json on cdnjs must have their own filename info, not only the auto-update libs.

Copy link
Contributor

@pvnr0082t pvnr0082t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mottie There is a conflict. Please solve it, thank you.

@Mottie
Copy link
Contributor Author

Mottie commented Dec 2, 2016

Resubmitted as PR #9842

@Mottie Mottie closed this Dec 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants