Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add simplelightbox v1.7.2 with npm auto-update #6857

Closed
wants to merge 1 commit into from

Conversation

Piicksarn
Copy link
Contributor

@maruilian11 , would you mind to have a look at the pr?
The PR is referenced to issue #6690
The git repo : https://github.com/andreknieriem/simplelightbox

  • Not found on cdnjs repo
  • No already exist issue and PR
  • Notable popularity : Watch 18, Star 323, Fork 39
  • Project has public repository on famous online hosting platform (or been hosted on npm)
  • Has valid tags for each versions (for git auto-update)
  • Auto-update setup
  • Auto-update target/source is valid.
  • Auto-update filemap is correct.

Thank you!

{
"basePath": "dist",
"files": [
"**/*.+(js|css)"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to exclude scss instead of adding js|css, or maybe you use js|css|map instead will be better, for the future once the map file for css/js been added.

@Piicksarn
Copy link
Contributor Author

#7022

@Piicksarn Piicksarn closed this Feb 18, 2016
@Piicksarn Piicksarn deleted the simplelightbox branch September 7, 2016 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants