Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add anchor.js@1.0.6 w/ git autoupdate #7435

Merged
merged 1 commit into from
May 14, 2016

Conversation

Piicksarn
Copy link
Contributor

Checklist for Pull request or lib adding request issue follows the conventions.

Note that if you are using a distribution purpose repository/package, please also provide the url and other related info like popularity of the source code repo/package.

Profile of the lib

  • Git repository (required): https://github.com/cbopp-art/anchor
  • Official website (optional, not the repository): http://cbopp-art.github.io/anchor/
  • NPM package url (optional):
  • GitHub / Bitbucket popularity (required):
    • Count of stars: 34
    • Count of watchers: 4
    • Count of forks: 9
  • NPM download stats (optional):
    • Downloads in the last day:
    • Downloads in the last week:
    • Downloads in the last month:

Essential checklist

  • I'm the author of this library
    • I would like to add link to the page of this library on CDNJS on website / readme
  • This lib was not found on cdnjs repo
  • No already exist / duplicated issue and PR
  • The lib has notable popularity
    • More than 100 [Stars / Watchers / Forks] on [GitHub / Bitbucket]
    • More than 500 downloads stats per month on npm registry
  • Project has public repository on famous online hosting platform (or been hosted on npm)

Auto-update checklist

  • Has valid tags for each versions (for git auto-update)
  • Auto-update setup
  • Auto-update target/source is valid.
  • Auto-update filemap is correct.

Git commit checklist

  • The first line of commit message is less then 50 chars, be clean and clear, easy to understand.
  • The parent of the commit(s) in the PR is not old than 3 days.
  • Pull request is sending from a non-master branch with meaningful name.
  • Separate unrelated changes into different commits.
  • Use rebase to squash/fixup dummy/unnecessary commits into only one commit.
  • Close corresponding issue in commit message
  • Mention related issue(s), people in commit message, comment.

close #6667, cc @cbopp-art

@Piicksarn
Copy link
Contributor Author

@Amomo, would you please help me for checkout the pr?
Thank you!

@Piicksarn
Copy link
Contributor Author

@maruilian11, would you mind to help me for checking the pr?
thank you!!

@Piicksarn Piicksarn assigned maruilian11 and unassigned Amomo Mar 31, 2016
],
"version": "1.0.6",
"author": "Cornel Boppart (https://github.com/cbopp-art)",
"license": "deprecated_GPL-2.0+",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you tell me how you told it's deprecated_GPL-2.0+ not GPL-3.0? i saw GPL-3.0 here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i knew that, but if there is any uncertain object, we should at least open an issue then send the PR.

@PeterDaveHello
Copy link
Contributor

Ping.

@Piicksarn
Copy link
Contributor Author

@PeterDaveHello , i followed license.txt and modified the license part in package.json
Would you check it again?
Thanks

@PeterDaveHello
Copy link
Contributor

PeterDaveHello commented May 14, 2016

@Piicksarn I'm okay with "deprecated_GPL-2.0+", have no idea about the reason to use "GPL-3.0" here, have you confirmed with the author? If you didn't, why not just follow its package.json?

@PeterDaveHello PeterDaveHello self-assigned this May 14, 2016
@Piicksarn
Copy link
Contributor Author

@PeterDaveHello, sure!

@PeterDaveHello
Copy link
Contributor

@Piicksarn Let's rollback first, I don't want to have so many PR opened for a long time.

@PeterDaveHello
Copy link
Contributor

@Piicksarn use "deprecated_GPL-2.0+" first.

@Piicksarn
Copy link
Contributor Author

@PeterDaveHello , i have it modified and need u for taking a look! Thanks!

@PeterDaveHello PeterDaveHello changed the title add anchor.js@1.0.6 add anchor.js@1.0.6 w/ npm autoupdate May 14, 2016
@PeterDaveHello PeterDaveHello changed the title add anchor.js@1.0.6 w/ npm autoupdate add anchor.js@1.0.6 w/ git autoupdate May 14, 2016
@PeterDaveHello PeterDaveHello merged commit 081410a into cdnjs:master May 14, 2016
@PeterDaveHello
Copy link
Contributor

Okay, finally ...

@Piicksarn Piicksarn deleted the anchorjs branch September 7, 2016 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request] Add anchor.js
4 participants