-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add anchor.js@1.0.6 w/ git autoupdate #7435
Conversation
@Amomo, would you please help me for checkout the pr? |
@maruilian11, would you mind to help me for checking the pr? |
], | ||
"version": "1.0.6", | ||
"author": "Cornel Boppart (https://github.com/cbopp-art)", | ||
"license": "deprecated_GPL-2.0+", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you tell me how you told it's deprecated_GPL-2.0+
not GPL-3.0
? i saw GPL-3.0 here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i knew that, but if there is any uncertain object, we should at least open an issue then send the PR.
Ping. |
@PeterDaveHello , i followed license.txt and modified the license part in package.json |
@Piicksarn I'm okay with |
@PeterDaveHello, sure! |
@Piicksarn Let's rollback first, I don't want to have so many PR opened for a long time. |
@Piicksarn use "deprecated_GPL-2.0+" first. |
@PeterDaveHello , i have it modified and need u for taking a look! Thanks! |
Okay, finally ... |
Checklist for Pull request or lib adding request issue follows the conventions.
Note that if you are using a distribution purpose repository/package, please also provide the url and other related info like popularity of the source code repo/package.
Profile of the lib
Essential checklist
Auto-update checklist
Git commit checklist
close #6667, cc @cbopp-art