Add onecolor v3.0.2 with npm auto-update config #7878

x09326 · 2016-05-11T22:32:59Z

PR for #5928
@pvnr0082t please help me review it, thanks.
Checklist for Pull request or lib adding request issue follows the conventions.

Note that if you are using a distribution purpose repository/package, please also provide the url and other related info like popularity of the source code repo/package.

Profile of the lib

Git repository (required):https://github.com/One-com/one-color
Official website (optional, not the repository):
NPM package url (optional):https://www.npmjs.com/package/onecolor
GitHub / Bitbucket popularity (required):
- Count of stars:395
- Count of watchers:26
- Count of forks:23
NPM download stats (optional):
- Downloads in the last day:9953
- Downloads in the last week:48535
- Downloads in the last month:199759

Essential checklist

I'm the author of this library
- I would like to add link to the page of this library on CDNJS on website / readme
This lib was not found on cdnjs repo
No already exist / duplicated issue and PR
The lib has notable popularity
- More than 100 [Stars / Watchers / Forks] on [GitHub / Bitbucket]
- More than 500 downloads stats per month on npm registry
Project has public repository on famous online hosting platform (or been hosted on npm)

Auto-update checklist

Has valid tags for each versions (for git auto-update)
Auto-update setup
Auto-update target/source is valid.
Auto-update filemap is correct.

Git commit checklist

The first line of commit message is less then 50 chars, be clean and clear, easy to understand.
The parent of the commit(s) in the PR is not old than 3 days.
Pull request is sending from a non-master branch with meaningful name.
Separate unrelated changes into different commits.
Use rebase to squash/fixup dummy/unnecessary commits into only one commit.
Close corresponding issue in commit message
Mention related issue(s), people in commit message, comment.

cc #5928, cc @Munter

pvnr0082t · 2016-05-12T06:04:25Z

ajax/libs/onecolor/package.json

+    {
+      "basePath": "",
+      "files": [
+        "one-color.*"


This rule won't grab one-color-all.js and one-color-all.map

pvnr0082t · 2016-05-12T06:09:32Z

@x09326 Both of one-color-all.js and one-color.js have already been minified and have their map file. You don't need to minify again.

x09326 · 2016-05-13T08:27:24Z

@pvnr0082t
I have modified the package.json and removed the minfied files.
Please help me review it again, thanks.

pvnr0082t · 2016-05-13T09:14:31Z

ajax/libs/onecolor/package.json

+  ],
+  "authors": [
+    "Peter Müller",
+    "Andreas Lind"


@x09326 Any reason you remove the email info of the authors?
https://github.com/One-com/one-color/blob/master/package.json#L18
https://github.com/One-com/one-color/blob/master/package.json#L22

x09326 · 2016-05-13T09:39:34Z

@pvnr0082t
I added the email of the authors.
Please help me review it, thanks.

pvnr0082t · 2016-05-13T09:54:55Z

@PeterDaveHello I think this PR is ok. Please review it again, thank you.

PeterDaveHello · 2016-05-13T13:32:26Z

ajax/libs/onecolor/3.0.1/one-color-all.map

+    "/home/munter/git/one-color/lib/plugins/opaquer.js",
+    "/home/munter/git/one-color/lib/plugins/rotate.js",
+    "/home/munter/git/one-color/lib/plugins/saturate.js",
+    "/home/munter/git/one-color/lib/plugins/toAlpha.js"


Looks strange here, maybe we should drop this, @x09326 can you check this?

How to check it?
Ask the author?

Yes, you can confirm with its author, in fact, this could be your chance to know about js and map file.

We noticed that one in the last production build. Caused by one of the browserify plugins that can't handle relative path source maps if I recall correctly. Ping @papandreou

We did fix that with One-com/one-color@14762b7 but for some reason we didn't release a new version after that :/

Fixed in 3.0.2.

Thanks @Munter @papandreou 👍

PeterDaveHello · 2016-05-16T02:17:42Z

@x09326 you can update the the latest version, or just drop the map file in v3.0.1

x09326 · 2016-05-16T05:43:43Z

@pvnr0082t
I have updated the latest version v3.0.2.
Please help me review it, thanks.

PeterDaveHello · 2016-05-16T06:15:54Z

hmmmm ... maybe we don't need to wait for the fix next time, I shouldn't make this too complex.

PeterDaveHello · 2016-05-16T06:16:03Z

anyway, thanks you all.

PeterDaveHello · 2016-05-16T06:18:19Z

ajax/libs/onecolor/package.json

+  "name": "onecolor",
+  "filename": "one-color-all.js",
+  "description": "Javascript color object with implicit color space conversions. Supports RGB, HSV, HSL and CMYK with alpha channel.",
+  "license": "BSD-2-clause",


Since I didn't see this from upstream, @x09326 let's send a PR to contribute upstream having this.

PeterDaveHello · 2016-05-16T06:19:17Z

@x09326 you didn't rebase your branch with the latest master branch.

@Munter

cc cdnjs#5928, cc @Munter

x09326 · 2016-05-16T08:32:26Z

Okay, I will send a PR to contribute upstream.

@pvnr0082t
I have rebased it.
Please help me review it, thanks.

pvnr0082t · 2016-05-16T10:55:24Z

@PeterDaveHello I think this PR is ok. Please review it again, thank you.

x09326 assigned pvnr0082t May 11, 2016

PeterDaveHello added the in progress label May 11, 2016

pvnr0082t reviewed May 12, 2016
View reviewed changes

pvnr0082t assigned x09326 and unassigned pvnr0082t May 12, 2016

x09326 force-pushed the onecolor branch from 7062596 to fb31b5a Compare May 13, 2016 08:24

x09326 assigned pvnr0082t and unassigned x09326 May 13, 2016

pvnr0082t reviewed May 13, 2016
View reviewed changes

x09326 force-pushed the onecolor branch from fb31b5a to b3a9d95 Compare May 13, 2016 09:30

pvnr0082t assigned PeterDaveHello and unassigned pvnr0082t May 13, 2016

PeterDaveHello reviewed May 13, 2016
View reviewed changes

PeterDaveHello assigned x09326 and unassigned PeterDaveHello May 13, 2016

x09326 mentioned this pull request May 15, 2016

About the source map files One-com/one-color#32

Closed

x09326 force-pushed the onecolor branch from b3a9d95 to 595520d Compare May 16, 2016 05:41

x09326 changed the title ~~Add onecolor v3.0.1 with npm auto-update config~~ Add onecolor v3.0.2 with npm auto-update config May 16, 2016

PeterDaveHello reviewed May 16, 2016
View reviewed changes

Add onecolor v3.0.2 with npm auto-update config

07e1968

cc cdnjs#5928, cc @Munter

x09326 force-pushed the onecolor branch from 595520d to 07e1968 Compare May 16, 2016 06:23

pvnr0082t assigned PeterDaveHello and unassigned x09326 May 16, 2016

PeterDaveHello merged commit d73b8c7 into cdnjs:master May 16, 2016

PeterDaveHello removed the in progress label May 16, 2016

x09326 deleted the onecolor branch October 12, 2016 11:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add onecolor v3.0.2 with npm auto-update config #7878

Add onecolor v3.0.2 with npm auto-update config #7878

x09326 commented May 11, 2016

pvnr0082t May 12, 2016 •

edited

pvnr0082t commented May 12, 2016

x09326 commented May 13, 2016

pvnr0082t May 13, 2016

x09326 commented May 13, 2016

pvnr0082t commented May 13, 2016

PeterDaveHello May 13, 2016

x09326 May 14, 2016

PeterDaveHello May 14, 2016

Munter May 15, 2016

papandreou May 15, 2016

papandreou May 15, 2016

PeterDaveHello May 16, 2016

PeterDaveHello commented May 16, 2016

x09326 commented May 16, 2016

PeterDaveHello commented May 16, 2016

PeterDaveHello commented May 16, 2016

PeterDaveHello May 16, 2016

PeterDaveHello commented May 16, 2016

x09326 commented May 16, 2016

pvnr0082t commented May 16, 2016

Add onecolor v3.0.2 with npm auto-update config #7878

Add onecolor v3.0.2 with npm auto-update config #7878

Conversation

x09326 commented May 11, 2016

Profile of the lib

Essential checklist

Auto-update checklist

Git commit checklist

pvnr0082t May 12, 2016 • edited

Choose a reason for hiding this comment

pvnr0082t commented May 12, 2016

x09326 commented May 13, 2016

Choose a reason for hiding this comment

x09326 commented May 13, 2016

pvnr0082t commented May 13, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

PeterDaveHello commented May 16, 2016

x09326 commented May 16, 2016

PeterDaveHello commented May 16, 2016

PeterDaveHello commented May 16, 2016

Choose a reason for hiding this comment

PeterDaveHello commented May 16, 2016

x09326 commented May 16, 2016

pvnr0082t commented May 16, 2016

pvnr0082t May 12, 2016 •

edited